Skip to content

Commit

Permalink
dt-bindings: phy: qcom,qmp: IPQ6018 and IPQ8074 PCIe PHY require no s…
Browse files Browse the repository at this point in the history
…upply

The qmp-phy driver suggests that 'vdda-phy-supply' and 'vdda-pll-supply'
are not required for IPQ6018 and IPQ8074 QMP PCIe PHY.  Update the
bindings to reflect it.

While at it, also correct the clock properties for IPQ8074 QMP PCIe PHY.
And as the result, 'qcom,ipq8074-qmp-pcie-phy' and
'qcom,ipq6018-qmp-pcie-phy' share the same clock, reset and supply
bindings.

Signed-off-by: Shawn Guo <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Vinod Koul <[email protected]>
  • Loading branch information
shawnguo2 authored and vinodkoul committed Oct 26, 2021
1 parent 2f5e9f8 commit d8b951a
Showing 1 changed file with 31 additions and 24 deletions.
55 changes: 31 additions & 24 deletions Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,6 @@ required:
- clock-names
- resets
- reset-names
- vdda-phy-supply
- vdda-pll-supply

additionalProperties: false

Expand Down Expand Up @@ -151,6 +149,9 @@ allOf:
items:
- const: phy
- const: common
required:
- vdda-phy-supply
- vdda-pll-supply
- if:
properties:
compatible:
Expand All @@ -177,6 +178,9 @@ allOf:
items:
- const: phy
- const: common
required:
- vdda-phy-supply
- vdda-pll-supply
- if:
properties:
compatible:
Expand Down Expand Up @@ -205,6 +209,9 @@ allOf:
- const: phy
- const: common
- const: cfg
required:
- vdda-phy-supply
- vdda-pll-supply
- if:
properties:
compatible:
Expand Down Expand Up @@ -234,6 +241,9 @@ allOf:
items:
- const: phy
- const: common
required:
- vdda-phy-supply
- vdda-pll-supply
- if:
properties:
compatible:
Expand All @@ -254,6 +264,9 @@ allOf:
reset-names:
items:
- const: ufsphy
required:
- vdda-phy-supply
- vdda-pll-supply
- if:
properties:
compatible:
Expand All @@ -279,34 +292,16 @@ allOf:
reset-names:
items:
- const: ufsphy
- if:
properties:
compatible:
contains:
enum:
- qcom,ipq8074-qmp-pcie-phy
then:
properties:
clocks:
items:
- description: pipe clk.
clock-names:
items:
- const: pipe_clk
resets:
items:
- description: reset of phy block.
- description: phy common block reset.
reset-names:
items:
- const: phy
- const: common
required:
- vdda-phy-supply
- vdda-pll-supply
- if:
properties:
compatible:
contains:
enum:
- qcom,ipq6018-qmp-pcie-phy
- qcom,ipq8074-qmp-pcie-phy
then:
properties:
clocks:
Expand Down Expand Up @@ -357,6 +352,9 @@ allOf:
reset-names:
items:
- const: phy
required:
- vdda-phy-supply
- vdda-pll-supply
- if:
properties:
compatible:
Expand Down Expand Up @@ -388,6 +386,9 @@ allOf:
items:
- const: phy
- const: common
required:
- vdda-phy-supply
- vdda-pll-supply
- if:
properties:
compatible:
Expand Down Expand Up @@ -415,6 +416,9 @@ allOf:
items:
- const: phy
- const: common
required:
- vdda-phy-supply
- vdda-pll-supply
- if:
properties:
compatible:
Expand All @@ -441,6 +445,9 @@ allOf:
items:
- const: phy_phy
- const: phy
required:
- vdda-phy-supply
- vdda-pll-supply

examples:
- |
Expand Down

0 comments on commit d8b951a

Please sign in to comment.