Skip to content

Commit

Permalink
s390/qdio: use dev_info() in qdio_print_subchannel_info()
Browse files Browse the repository at this point in the history
Prefer dev_info() over a raw printk. This also adds the device and
driver names into the output, so that we have:

Before:
    qdio: 0.0.17c0 ZFCP on SC 17 using [...]

After:
    zfcp 0.0.17c0: qdio: ZFCP on SC 17 using [...]

Signed-off-by: Julian Wiedmann <[email protected]>
Reviewed-by: Benjamin Block <[email protected]>
Signed-off-by: Vasily Gorbik <[email protected]>
  • Loading branch information
julianwiedmann authored and Vasily Gorbik committed Aug 18, 2021
1 parent 87e225b commit f86991b
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions drivers/s390/cio/qdio_setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -479,10 +479,8 @@ void qdio_shutdown_irq(struct qdio_irq *irq)

void qdio_print_subchannel_info(struct qdio_irq *irq_ptr)
{
char s[80];

snprintf(s, 80, "qdio: %s %s on SC %x using AI:%d QEBSM:%d PRI:%d TDD:%d SIGA:%s%s%s\n",
dev_name(&irq_ptr->cdev->dev),
dev_info(&irq_ptr->cdev->dev,
"qdio: %s on SC %x using AI:%d QEBSM:%d PRI:%d TDD:%d SIGA:%s%s%s\n",
(irq_ptr->qib.qfmt == QDIO_QETH_QFMT) ? "OSA" :
((irq_ptr->qib.qfmt == QDIO_ZFCP_QFMT) ? "ZFCP" : "HS"),
irq_ptr->schid.sch_no,
Expand All @@ -493,7 +491,6 @@ void qdio_print_subchannel_info(struct qdio_irq *irq_ptr)
qdio_need_siga_in(irq_ptr) ? "R" : " ",
qdio_need_siga_out(irq_ptr) ? "W" : " ",
qdio_need_siga_sync(irq_ptr) ? "S" : " ");
printk(KERN_INFO "%s", s);
}

int __init qdio_setup_init(void)
Expand Down

0 comments on commit f86991b

Please sign in to comment.