Skip to content

Commit

Permalink
[SCSI] qla2xxx: Correct swing/emphasis settings for ISP24XX.
Browse files Browse the repository at this point in the history
Swing/emphasis settings in NVRAM were not being honoured due
to the driver not converting the serial-link options from LE
to host-endian format.

Signed-off-by: Andrew Vasquez <[email protected]>
Signed-off-by: James Bottomley <[email protected]>
  • Loading branch information
avasquez01 authored and James Bottomley committed Jan 14, 2006
1 parent c9d02ac commit f94097e
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions drivers/scsi/qla2xxx/qla_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -1014,11 +1014,13 @@ qla24xx_update_fw_options(scsi_qla_host_t *ha)
int rval;

/* Update Serial Link options. */
if ((ha->fw_seriallink_options24[0] & BIT_0) == 0)
if ((le16_to_cpu(ha->fw_seriallink_options24[0]) & BIT_0) == 0)
return;

rval = qla2x00_set_serdes_params(ha, ha->fw_seriallink_options24[1],
ha->fw_seriallink_options24[2], ha->fw_seriallink_options24[3]);
rval = qla2x00_set_serdes_params(ha,
le16_to_cpu(ha->fw_seriallink_options24[1]),
le16_to_cpu(ha->fw_seriallink_options24[2]),
le16_to_cpu(ha->fw_seriallink_options24[3]));
if (rval != QLA_SUCCESS) {
qla_printk(KERN_WARNING, ha,
"Unable to update Serial Link options (%x).\n", rval);
Expand Down

0 comments on commit f94097e

Please sign in to comment.