openvswitch: switch from WARN to pr_warn

As noted by Paolo Abeni, pr_warn doesn't generate any splat and can still preserve the warning to the user that feature downgrade occurred. We likely cannot introduce other kinds of checks / enforcement here because syzbot can generate different genl versions to the datapath. Reported-by: [email protected] Fixes: 44da5ae ("openvswitch: Drop user features if old user space attempted to create datapath") Cc: Thomas Graf <[email protected]> Signed-off-by: Aaron Conole <[email protected]> Acked-by: Ilya Maximets <[email protected]> Signed-off-by: Paolo Abeni <[email protected]>
kawasaki · Oct 27, 2022 · fd954cc · fd954cc
1 parent e2badb4
commit fd954cc
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
@@ -1616,7 +1616,8 @@ static void ovs_dp_reset_user_features(struct sk_buff *skb,
 	if (IS_ERR(dp))
 		return;
 
-	WARN(dp->user_features, "Dropping previously announced user features\n");
+	pr_warn("%s: Dropping previously announced user features\n",
+		ovs_dp_name(dp));
 	dp->user_features = 0;
 }