Fix store_failures modifier for unique, not_null (dbt-labs#3577)

* Fix store_failures modifier for unique, not_null

* Add test, changelog

CHANGELOG.md

@@ -20,6 +20,13 @@ Contributors:
 - [@JLDLaughlin](https://github.com/JLDLaughlin) ([#3473](https://github.com/fishtown-analytics/dbt/pull/3473))
 - [@jmriego](https://github.com/jmriego) ([#3526](https://github.com/dbt-labs/dbt/pull/3526))
 
+
+## dbt 0.20.1 (Release TBD)
+
+### Fixes
+- Fix `store_failures` config when defined as a modifier for `unique` and `not_null` tests ([#3575](https://github.com/fishtown-analytics/dbt/issues/3575), [#3577](https://github.com/fishtown-analytics/dbt/pull/3577))
+
+
 ## dbt 0.20.0 (July 12, 2021)
 
 ### Fixes

core/dbt/parser/schemas.py

@@ -388,6 +388,9 @@ def render_test_update(self, node, config, builder):
             if builder.fail_calc is not None:
                 node.unrendered_config['fail_calc'] = builder.fail_calc
                 node.config['fail_calc'] = builder.fail_calc
+            if builder.store_failures is not None:
+                node.unrendered_config['store_failures'] = builder.store_failures
+                node.config['store_failures'] = builder.store_failures
             # source node tests are processed at patch_source time
             if isinstance(builder.target, UnpatchedSourceDefinition):
                 sources = [builder.target.fqn[-2], builder.target.fqn[-1]]

test/integration/067_store_test_failures_tests/models/schema.yml

@@ -13,7 +13,8 @@ models:
     columns:
       - name: id
         tests:
-          - unique
+          - unique:
+              store_failures: true
           - not_null
       - name: first_name
         tests:

test/integration/067_store_test_failures_tests/test_store_test_failures.py

@@ -28,13 +28,23 @@ def project_config(self):
 
     def column_type_overrides(self):
         return {}
+
+    def run_tests_store_one_failure(self):
+        test_audit_schema = self.unique_schema() + "_dbt_test__audit"
+
+        self.run_dbt(["seed"])
+        self.run_dbt(["run"])
+        self.run_dbt(["test"], expect_pass=False)
+
+        # one test is configured with store_failures: true, make sure it worked
+        self.assertTablesEqual("unique_problematic_model_id", "expected_unique_problematic_model_id", test_audit_schema)
 
     def run_tests_store_failures_and_assert(self):
         test_audit_schema = self.unique_schema() + "_dbt_test__audit"
 
         self.run_dbt(["seed"])
         self.run_dbt(["run"])
-        # make sure this works idempotently
+        # make sure this works idempotently for all tests
         self.run_dbt(["test", "--store-failures"], expect_pass=False)
         results = self.run_dbt(["test", "--store-failures"], expect_pass=False)
 
@@ -71,6 +81,7 @@ def column_type_overrides(self):
 
     @use_profile('postgres')
     def test__postgres__store_and_assert(self):
+        self.run_tests_store_one_failure()
         self.run_tests_store_failures_and_assert()
 
 class RedshiftTestStoreTestFailures(TestStoreTestFailures):