Skip to content

Commit

Permalink
[hotfix] Repair ineffective LocalRecoveryITCase
Browse files Browse the repository at this point in the history
The test did not actually run since the class was refactored with JUnit's parameterized, because it was always running into a NPE and the NPE was then silently swallowed in a shutdown catch-block.
  • Loading branch information
StefanRRichter committed Feb 25, 2019
1 parent c2d6424 commit 168660a
Showing 1 changed file with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,15 @@ protected Configuration createClusterConfig() throws IOException {

private void executeTest(EventTimeWindowCheckpointingITCase delegate) throws Exception {
delegate.name = testName;
delegate.stateBackendEnum = backendEnum;
try {
delegate.setupTestCluster();
try {
delegate.testTumblingTimeWindow();
delegate.stopTestCluster();
} catch (Exception e) {
delegate.stopTestCluster();
throw new RuntimeException(e);
}

delegate.setupTestCluster();
Expand All @@ -102,9 +104,10 @@ private void executeTest(EventTimeWindowCheckpointingITCase delegate) throws Exc
delegate.stopTestCluster();
} catch (Exception e) {
delegate.stopTestCluster();
throw new RuntimeException(e);
}
} finally {
delegate.tempFolder.delete();
EventTimeWindowCheckpointingITCase.tempFolder.delete();
}
}
}

0 comments on commit 168660a

Please sign in to comment.