Handle init=False fields with a missing value. Fixes konradhalas#44.

kc2684 · Apr 13, 2019 · fed8293 · fed8293
1 parent 99c3723
commit fed8293
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/dacite/core.py b/dacite/core.py
@@ -58,6 +58,8 @@ def from_dict(data_class: Type[T], data: Data, config: Optional[Config] = None)
             try:
                 value = get_default_value_for_field(field)
             except DefaultValueNotFoundError:
+                if not field.init:
+                    continue
                 raise MissingValueError(field.name)
         if field.init:
             init_values[field.name] = value

diff --git a/tests/core/test_base.py b/tests/core/test_base.py
@@ -145,6 +145,16 @@ class X:
     assert result == x
 
 
+def test_from_dict_with_post_init_missing_value():
+    @dataclass
+    class X:
+        s: str = field(init=False)
+
+    result = from_dict(X, {})
+
+    assert not hasattr(result, "s")
+
+
 def test_from_dict_with_new_type():
     MyStr = NewType("MyStr", str)