Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "Open in JsBin/JsFiddle", switched localstorage to chrome.storage.local #71

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

KartikSoneji
Copy link

@KartikSoneji KartikSoneji commented Jan 11, 2020

Fixes Issue #66 and Issue #50

Related: Issue #55 is fixed, so should be closed.

@KartikSoneji
Copy link
Author

Also implemented Feature #60

@kdzwinel
Copy link
Owner

Thanks a lot! Much appreciated. I'm worried about that jsbin approach though - extacting _csrf token seems very fragile. Do you know if there is any working jsbin API? If not, how about we open https://jsbin.com/?html,css,output in a new tab and just automatically paste HTML and CSS into correct inputs? This approach could work for all jsbin/codepen/jsfiddle.

@KartikSoneji
Copy link
Author

No, I could not find any API for JsBin, I have reverse-engineered the POST request from the JsBin page to get it to work.

JsFiddle and CodePen do have documented public APIs, and I think that it is better to use them.
Opening https://jsbin.com/?html,css,output in a new tab and pasting HTML and CSS will be difficult, as it will involve transmitting data across tabs.
I do not see how this can be done reliably.

The current solution may be fragile, but I do not see any other way of supporting JsBin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants