Skip to content

Commit

Permalink
Merge pull request twitchtv#241 from ofpiyush/add_twirpy
Browse files Browse the repository at this point in the history
Clarify generator language server and client support, add twirpy
  • Loading branch information
dpolansky authored May 23, 2020
2 parents 2bffe5f + b9ff3c6 commit 039414d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,14 @@ is generated from that folder using [Docusaurus](https://docusaurus.io/).

### Implementations in other languages

This repo only has the official generators, which write out Go and Python code.
This repo only has the official generators, which write out Go and
Python (partial, see [#185](https://github.com/twitchtv/twirp/issues/185) and [#220](https://github.com/twitchtv/twirp/issues/220)) code.

For other languages, there are third-party generators available:

| Language | Clients | Servers | Repository |
|----------------|---------|---------|------------|
| **Python3** | ✓ | ✓ | [github.com/verloop/twirpy](https://github.com/verloop/twirpy)
| **Java** | ✓ | ✓ | [github.com/fajran/protoc-gen-twirp_java_jaxrs](https://github.com/fajran/protoc-gen-twirp_java_jaxrs)
| **Java** | | ✓ | [https://github.com/devork/flit](https://github.com/devork/flit)
| **JavaScript** | ✓ | | [github.com/thechriswalker/protoc-gen-twirp_js](https://github.com/thechriswalker/protoc-gen-twirp_js)
Expand Down
4 changes: 2 additions & 2 deletions errors_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func TestWithMetaRaces(t *testing.T) {
}

func TestErrorCause(t *testing.T) {
rootCause := fmt.Errorf("this is only a test")
rootCause := errors.New("this is only a test")
twerr := InternalErrorWith(rootCause)
cause := errors.Cause(twerr)
if cause != rootCause {
Expand All @@ -57,7 +57,7 @@ type errorResponeWriter struct {
}

func (errorResponeWriter) Write([]byte) (int, error) {
return 0, fmt.Errorf("this is only a test")
return 0, errors.New("this is only a test")
}

func TestWriteError(t *testing.T) {
Expand Down

0 comments on commit 039414d

Please sign in to comment.