Remove hermes_fatal from SamplingProfiler destructor

Summary:
This diff removes (temporarily) the requirement that the sampling profiler
should be destroying in the same thread it is created. This unblocks fixes
several (otherwise harmless) crashes.

Reviewed By: neildhar

Differential Revision: D37796218

fbshipit-source-id: f1562e440fa4be7b09b19ba28b6ebc3f1c8988d1

lib/VM/Profiler/SamplingProfilerPosix.cpp

@@ -63,9 +63,8 @@ void SamplingProfiler::GlobalProfiler::unregisterRuntime(
   (void)succeed;
 
 #if defined(__ANDROID__) && defined(HERMES_FACEBOOK_BUILD)
-  assert(
-      threadLocalProfilerForLoom_.get() == profiler &&
-      "invalid hermes runtime for this thread");
+  // TODO(T125910634): re-introduce the requirement for unregistering the
+  // runtime in the same thread it was registered.
   threadLocalProfilerForLoom_.set(nullptr);
 #endif
 }
@@ -409,11 +408,8 @@ SamplingProfiler::SamplingProfiler(Runtime &runtime)
 }
 
 SamplingProfiler::~SamplingProfiler() {
-  if (pthread_self() != currentThread_) {
-    ::hermes::hermes_fatal(
-        "SamplingProfiler should be destroyed on the same thread it is "
-        "created");
-  }
+  // TODO(T125910634): re-introduce the requirement for destroying the sampling
+  // profiler on the same thread in which it was created.
   GlobalProfiler::get()->unregisterRuntime(this);
 }
 

unittests/API/CMakeLists.txt

@@ -17,9 +17,6 @@ set(APITestsSources
 set(APISegmentTestCompileSources
   SegmentTestCompile.cpp
   )
-set(SamplingProfilerSources
-  SamplingProfilerPosixHermesAPITest.cpp
-  )
 
 set(HERMES_LINK_COMPONENTS LLVHSupport)
 
@@ -39,6 +36,3 @@ target_link_libraries(APITests hermesapi compileJS SegmentTestCompile traceInter
 
 add_hermes_unittest(APILeanTests APILeanTest.cpp)
 target_link_libraries(APILeanTests hermesapiLean)
-
-add_hermes_unittest(SamplingProfilerTests ${SamplingProfilerSources})
-target_link_libraries(SamplingProfilerTests hermesapiLean hermesVMRuntimeLean)