Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to SSH Agent streams #11290

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Add timeout to SSH Agent streams #11290

merged 1 commit into from
Nov 10, 2024

Conversation

droidmonkey
Copy link
Member

Testing strategy

Pending testing in a replicated environment

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.76%. Comparing base (5d24495) to head (cd2b2da).
Report is 19 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11290      +/-   ##
===========================================
- Coverage    63.78%   63.76%   -0.02%     
===========================================
  Files          362      362              
  Lines        38072    38070       -2     
===========================================
- Hits         24282    24273       -9     
- Misses       13790    13797       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@varjolintu
Copy link
Member

I couldn't get the reproduce steps to work. If I make a custom systemd service everything works as expected, but without it the agent doesn't even run.

@droidmonkey
Copy link
Member Author

Merging this since OP said it fixed their issue and there is no harm in having a defined timeout as 99% of the time the transaction is near instant.

@droidmonkey droidmonkey merged commit 6e81451 into develop Nov 10, 2024
11 checks passed
@droidmonkey droidmonkey deleted the fix/sshagent-timeout branch November 10, 2024 14:15
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: SSH agent pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App freezes after entering master password - ssh-agent deadlock
3 participants