Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split arq workers to different process #4177

Merged
merged 45 commits into from
Mar 26, 2025
Merged

feat: split arq workers to different process #4177

merged 45 commits into from
Mar 26, 2025

Conversation

shahargl
Copy link
Member

@shahargl shahargl commented Mar 23, 2025

close #4178
close #4024
close #4186

Copy link

vercel bot commented Mar 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2025 8:22am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Feature A new feature labels Mar 23, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Mar 23, 2025
Copy link

codecov bot commented Mar 23, 2025

Codecov Report

Attention: Patch coverage is 55.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 30.99%. Comparing base (b1d0c31) to head (5cea8d8).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/logging.py 58.33% 5 Missing ⚠️
keep/api/tasks/process_event_task.py 0.00% 2 Missing ⚠️
keep/api/consts.py 75.00% 1 Missing ⚠️
keep/workflowmanager/workflowmanager.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4177      +/-   ##
==========================================
+ Coverage   30.95%   30.99%   +0.03%     
==========================================
  Files          92       92              
  Lines       10257    10309      +52     
==========================================
+ Hits         3175     3195      +20     
- Misses       7082     7114      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Matvey-Kuk
Matvey-Kuk previously approved these changes Mar 24, 2025
@talboren
Copy link
Member

👑

Copy link
Contributor

@VladimirFilonov VladimirFilonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahargl shahargl merged commit 0383075 into main Mar 26, 2025
19 of 21 checks passed
@shahargl shahargl deleted the feature/split-arq branch March 26, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
4 participants