coverity 263769 dereference before null check

keke1023 · Oct 23, 2019 · 30da3cf · 30da3cf
1 parent e872ac5
commit 30da3cf
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/common/crapto1/crypto1.c b/common/crapto1/crypto1.c
@@ -26,12 +26,11 @@
     (x = (x >> 8 & 0xff00ff) | (x & 0xff00ff) << 8, x = x >> 16 | x << 16)
 
 void crypto1_init(struct Crypto1State *state, uint64_t key) {
+    if (state == NULL)
+        return;
     state->odd = 0;
     state->even = 0;
-
-    int i;
-
-    for (i = 47; state && i > 0; i -= 2) {
+    for (int i = 47; i > 0; i -= 2) {
         state->odd  = state->odd  << 1 | BIT(key, (i - 1) ^ 7);
         state->even = state->even << 1 | BIT(key, i ^ 7);
     }