Skip to content

Commit

Permalink
Revert Reactor Bismuth-SR1 work arounds as it is now in Central
Browse files Browse the repository at this point in the history
This commit reverts:

 - 362735c
 - a6a8195

Closes spring-projectsgh-10738
  • Loading branch information
wilkinsona committed Oct 21, 2017
1 parent a6a8195 commit b7ce3e0
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 24 deletions.
8 changes: 0 additions & 8 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,6 @@
<enabled>false</enabled>
</snapshots>
</repository>
<repository>
<id>spring-release</id>
<name>Spring Release</name>
<url>https://repo.spring.io/ext-release-local</url>
<snapshots>
<enabled>false</enabled>
</snapshots>
</repository>
<repository>
<id>spring-milestone</id>
<name>Spring Milestone</name>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,6 @@ public static List<RepositoryConfiguration> createDefaultRepositoryConfiguration
MavenSettings mavenSettings = new MavenSettingsReader().readSettings();
List<RepositoryConfiguration> repositoryConfiguration = new ArrayList<>();
repositoryConfiguration.add(MAVEN_CENTRAL);
repositoryConfiguration.add(new RepositoryConfiguration("spring-ext-release",
URI.create("https://repo.spring.io/ext-release-local"), false));
if (!Boolean.getBoolean("disableSpringSnapshotRepos")) {
repositoryConfiguration.add(SPRING_MILESTONE);
repositoryConfiguration.add(SPRING_SNAPSHOT);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public void defaultRepositories() {
List<RepositoryConfiguration> repositoryConfiguration = RepositoryConfigurationFactory
.createDefaultRepositoryConfiguration();
assertRepositoryConfiguration(repositoryConfiguration, "central", "local",
"spring-snapshot", "spring-milestone", "spring-ext-release");
"spring-snapshot", "spring-milestone");
}, "user.home:src/test/resources/maven-settings/basic");
}

Expand All @@ -49,8 +49,7 @@ public void snapshotRepositoriesDisabled() {
SystemProperties.doWithSystemProperties(() -> {
List<RepositoryConfiguration> repositoryConfiguration = RepositoryConfigurationFactory
.createDefaultRepositoryConfiguration();
assertRepositoryConfiguration(repositoryConfiguration, "central", "local",
"spring-ext-release");
assertRepositoryConfiguration(repositoryConfiguration, "central", "local");
}, "user.home:src/test/resources/maven-settings/basic",
"disableSpringSnapshotRepos:true");
}
Expand All @@ -61,8 +60,7 @@ public void activeByDefaultProfileRepositories() {
List<RepositoryConfiguration> repositoryConfiguration = RepositoryConfigurationFactory
.createDefaultRepositoryConfiguration();
assertRepositoryConfiguration(repositoryConfiguration, "central", "local",
"spring-snapshot", "spring-milestone", "active-by-default",
"spring-ext-release");
"spring-snapshot", "spring-milestone", "active-by-default");
}, "user.home:src/test/resources/maven-settings/active-profile-repositories");
}

Expand All @@ -72,8 +70,7 @@ public void activeByPropertyProfileRepositories() {
List<RepositoryConfiguration> repositoryConfiguration = RepositoryConfigurationFactory
.createDefaultRepositoryConfiguration();
assertRepositoryConfiguration(repositoryConfiguration, "central", "local",
"spring-snapshot", "spring-milestone", "active-by-property",
"spring-ext-release");
"spring-snapshot", "spring-milestone", "active-by-property");
}, "user.home:src/test/resources/maven-settings/active-profile-repositories",
"foo:bar");
}
Expand All @@ -85,7 +82,7 @@ public void interpolationProfileRepositories() {
.createDefaultRepositoryConfiguration();
assertRepositoryConfiguration(repositoryConfiguration, "central", "local",
"spring-snapshot", "spring-milestone", "interpolate-releases",
"interpolate-snapshots", "spring-ext-release");
"interpolate-snapshots");
}, "user.home:src/test/resources/maven-settings/active-profile-repositories",
"interpolate:true");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,6 @@ public class AetherGrapeEngineTests {
private final RepositoryConfiguration springMilestones = new RepositoryConfiguration(
"spring-milestones", URI.create("https://repo.spring.io/milestone"), false);

private final RepositoryConfiguration springExtRelease = new RepositoryConfiguration(
"spring-milestones", URI.create("https://repo.spring.io/ext-release-local"),
false);

private AetherGrapeEngine createGrapeEngine(
RepositoryConfiguration... additionalRepositories) {
List<RepositoryConfiguration> repositoryConfigurations = new ArrayList<>();
Expand All @@ -69,7 +65,7 @@ private AetherGrapeEngine createGrapeEngine(
@Test
public void dependencyResolution() {
Map<String, Object> args = new HashMap<>();
createGrapeEngine(this.springMilestones, this.springExtRelease).grab(args,
createGrapeEngine(this.springMilestones).grab(args,
createDependency("org.springframework", "spring-jdbc", null));
assertThat(this.groovyClassLoader.getURLs()).hasSize(5);
}
Expand Down Expand Up @@ -134,7 +130,7 @@ public void dependencyResolutionWithCustomClassLoader() {
GroovyClassLoader customClassLoader = new GroovyClassLoader();
args.put("classLoader", customClassLoader);

createGrapeEngine(this.springMilestones, this.springExtRelease).grab(args,
createGrapeEngine(this.springMilestones).grab(args,
createDependency("org.springframework", "spring-jdbc", null));

assertThat(this.groovyClassLoader.getURLs().length).isEqualTo(0);
Expand Down

0 comments on commit b7ce3e0

Please sign in to comment.