Revert "GEODE-8432: use regionPath directly instead of getRegion when…

… put eve… (apache#5459)" (apache#5461) This reverts commit 8021084 so it can be re-submitted with fixes to simplify back-porting.
kekerzzZ · Aug 18, 2020 · 75a7aa5 · 75a7aa5
1 parent 8021084
commit 75a7aa5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 55 deletions.
diff --git a/...rc/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java b/...rc/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
@@ -693,14 +693,15 @@ public boolean put(Object object) throws InterruptedException, CacheException {
 
     boolean isDREvent = isDREvent(sender.getCache(), value);
 
-    String regionPath = value.getRegionPath();
-    if (!isDREvent) {
-      regionPath = ColocationHelper
-          .getLeaderRegion((PartitionedRegion) sender.getCache().getRegion(regionPath))
-          .getFullPath();
+    Region region = value.getRegion();
+    String regionPath = null;
+    if (isDREvent) {
+      regionPath = region.getFullPath();
+    } else {
+      regionPath = ColocationHelper.getLeaderRegion((PartitionedRegion) region).getFullPath();
     }
     if (isDebugEnabled) {
-      logger.debug("Put is for the region {}", regionPath);
+      logger.debug("Put is for the region {}", region);
     }
     if (!this.userRegionNameToShadowPRMap.containsKey(regionPath)) {
       if (isDebugEnabled) {

diff --git a/...ava/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueueJUnitTest.java b/...ava/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueueJUnitTest.java
@@ -17,9 +17,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.Assert.assertEquals;
 import static org.mockito.Mockito.any;
-import static org.mockito.Mockito.doReturn;
 import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.spy;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
@@ -39,7 +37,6 @@
 
 import org.apache.geode.CancelCriterion;
 import org.apache.geode.cache.DataPolicy;
-import org.apache.geode.cache.PartitionAttributes;
 import org.apache.geode.cache.PartitionAttributesFactory;
 import org.apache.geode.cache.Region;
 import org.apache.geode.internal.cache.AbstractBucketRegionQueue;
@@ -78,52 +75,6 @@ public void createParallelGatewaySenderQueue() {
         false);
   }
 
-  @Test
-  public void whenReplicatedDataRegionNotReadyShouldNotThrowException() throws Exception {
-    GatewaySenderEventImpl event = mock(GatewaySenderEventImpl.class);
-    when(event.makeHeapCopyIfOffHeap()).thenReturn(event);
-    when(event.getRegion()).thenReturn(null);
-    String regionPath = "/testRegion";
-    when(event.getRegionPath()).thenReturn(regionPath);
-    Mockito.doThrow(new IllegalStateException()).when(event).release();
-    Queue backingList = new LinkedList();
-    backingList.add(event);
-
-    queue = spy(queue);
-    doReturn(true).when(queue).isDREvent(any(), any());
-    boolean putDone = queue.put(event);
-    assertThat(putDone).isFalse();
-  }
-
-  @Test
-  public void whenPartitionedDataRegionNotReadyShouldNotThrowException() throws Exception {
-    GatewaySenderEventImpl event = mock(GatewaySenderEventImpl.class);
-    when(event.makeHeapCopyIfOffHeap()).thenReturn(event);
-    when(event.getRegion()).thenReturn(null);
-    String regionPath = "/testRegion";
-    when(event.getRegionPath()).thenReturn(regionPath);
-    PartitionedRegion region = mock(PartitionedRegion.class);
-    when(region.getFullPath()).thenReturn(regionPath);
-    when(cache.getRegion(regionPath)).thenReturn(region);
-    PartitionAttributes pa = mock(PartitionAttributes.class);
-    when(region.getPartitionAttributes()).thenReturn(pa);
-    when(pa.getColocatedWith()).thenReturn(null);
-
-    Mockito.doThrow(new IllegalStateException()).when(event).release();
-    Queue backingList = new LinkedList();
-    backingList.add(event);
-
-    BucketRegionQueue bucketRegionQueue = mockBucketRegionQueue(backingList);
-
-    TestableParallelGatewaySenderQueue queue = new TestableParallelGatewaySenderQueue(sender,
-        Collections.emptySet(), 0, 1, metaRegionFactory);
-    queue.setMockedAbstractBucketRegionQueue(bucketRegionQueue);
-
-    queue = spy(queue);
-    boolean putDone = queue.put(event);
-    assertThat(putDone).isFalse();
-  }
-
   @Test
   public void whenEventReleaseFromOffHeapFailsExceptionShouldNotBeThrownToAckReaderThread()
       throws Exception {