Cleanup: elm-review

TODO.md

@@ -1,6 +1,3 @@
-- update readme
-  - new way to set column width with snippet
-
 - need to update collapsed columns if columns are added or removed
 
 - set size in elm (resize_spike branch)

src/Board.elm

@@ -6,7 +6,7 @@ module Board exposing
 
 import BoardConfig exposing (BoardConfig)
 import Card exposing (Card)
-import CollapsedColumns
+import CollapsedColumns exposing (CollapsedColumns)
 import Column exposing (Column)
 import ColumnNames exposing (ColumnNames)
 import DateBoardColumns exposing (DateBoardColumns)
@@ -75,17 +75,19 @@ columns timeWithZone boardIndex (Board columnNames config taskList) =
 collapseColumns : BoardConfig -> List (Column Card) -> List (Column Card)
 collapseColumns config cols =
     let
+        collapsedColumns : CollapsedColumns
         collapsedColumns =
             BoardConfig.collapsedColumns config
 
-        foo index col =
+        performCollapse : Int -> Column Card -> Column Card
+        performCollapse index col =
             if CollapsedColumns.columnIsCollapsed index collapsedColumns then
                 Column.collapseState True col
 
             else
                 Column.collapseState False col
     in
-    List.indexedMap foo cols
+    List.indexedMap performCollapse cols
 
 
 filterTaskList : BoardConfig -> TaskList -> TaskList

src/CollapsedColumns.elm

@@ -7,7 +7,6 @@ module CollapsedColumns exposing
     , init
     )
 
-import List.Extra as LE
 import Set exposing (Set)
 import TsJson.Decode as TsDecode
 import TsJson.Encode as TsEncode

src/Page/Board.elm

@@ -93,6 +93,7 @@ update msg session =
 
         ToggleColumnCollapse columnIndex newState ->
             let
+                newSession : Session
                 newSession =
                     Session.updateColumnCollapse columnIndex newState session
             in
@@ -260,20 +261,23 @@ selectedBoardView timeWithZone boardIndex board =
 columnView : Int -> TimeWithZone -> Column Card -> Html Msg
 columnView columnIndex timeWithZone column =
     let
+        columnCollapsedArrow : String
         columnCollapsedArrow =
             if Column.isCollapsed column then
                 "arrow-down"
 
             else
                 "arrow-right"
 
+        columnCollapsedClass : String
         columnCollapsedClass =
             if Column.isCollapsed column then
                 " collapsed"
 
             else
                 ""
 
+        columnCountString : String
         columnCountString =
             if Column.isCollapsed column then
                 "(" ++ (String.fromInt <| List.length <| Column.items column) ++ ")"

tests/CollapsedColumnsTests.elm

@@ -2,7 +2,7 @@ module CollapsedColumnsTests exposing (suite)
 
 import CollapsedColumns
 import Expect
-import Fuzz exposing (Fuzzer)
+import Fuzz
 import Helpers.DecodeHelpers as DecodeHelpers
 import Test exposing (..)
 import TsJson.Encode as TsEncode