small syntax lints (bluesky-social#1646)

* lint: remove unused imports and variables * lint: prefix unused args with '_' * eslint: skip no-explicit-any; ignore unused _var (prefix) * eslint: explicitly mark ignores for tricky cases
kemerald25 · Sep 21, 2023 · 7e36c48 · 7e36c48
1 parent 462de21
commit 7e36c48
Show file tree

Hide file tree

Showing 19 changed files with 21 additions and 38 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -29,11 +29,12 @@
     "no-misleading-character-class": "warn",
     "@typescript-eslint/no-unused-vars": [
       "warn",
-      { "argsIgnorePattern": "^_" }
+      { "argsIgnorePattern": "^_", "varsIgnorePattern": "^_" }
     ],
     "@typescript-eslint/ban-ts-comment": "off",
     "@typescript-eslint/no-empty-interface": "off",
     "@typescript-eslint/explicit-module-boundary-types": "off",
-    "@typescript-eslint/no-empty-function": "off"
+    "@typescript-eslint/no-empty-function": "off",
+    "@typescript-eslint/no-explicit-any": "off"
   }
 }
diff --git a/packages/api/src/agent.ts b/packages/api/src/agent.ts
@@ -7,7 +7,6 @@ import {
   ComAtprotoServerCreateSession,
   ComAtprotoServerGetSession,
   ComAtprotoServerRefreshSession,
-  ComAtprotoRepoUploadBlob,
 } from './client'
 import {
   AtpSessionData,

diff --git a/packages/api/src/bsky-agent.ts b/packages/api/src/bsky-agent.ts
@@ -311,12 +311,14 @@ export class BskyAgent extends AtpAgent {
         AppBskyActorDefs.isFeedViewPref(pref) &&
         AppBskyActorDefs.validateFeedViewPref(pref).success
       ) {
+        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         const { $type, feed, ...v } = pref
         prefs.feedViewPrefs[pref.feed] = { ...FEED_VIEW_PREF_DEFAULTS, ...v }
       } else if (
         AppBskyActorDefs.isThreadViewPref(pref) &&
         AppBskyActorDefs.validateThreadViewPref(pref).success
       ) {
+        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         const { $type, ...v } = pref
         prefs.threadViewPrefs = { ...prefs.threadViewPrefs, ...v }
       }

diff --git a/packages/api/src/moderation/subjects/feed-generator.ts b/packages/api/src/moderation/subjects/feed-generator.ts
@@ -5,8 +5,8 @@ import {
 } from '../types'
 
 export function decideFeedGenerator(
-  subject: ModerationSubjectFeedGenerator,
-  opts: ModerationOpts,
+  _subject: ModerationSubjectFeedGenerator,
+  _opts: ModerationOpts,
 ): ModerationDecision {
   // TODO handle labels applied on the feed generator itself
   return ModerationDecision.noop()

diff --git a/packages/api/src/moderation/subjects/user-list.ts b/packages/api/src/moderation/subjects/user-list.ts
@@ -5,8 +5,8 @@ import {
 } from '../types'
 
 export function decideUserList(
-  subject: ModerationSubjectUserList,
-  opts: ModerationOpts,
+  _subject: ModerationSubjectUserList,
+  _opts: ModerationOpts,
 ): ModerationDecision {
   // TODO handle labels applied on the list itself
   return ModerationDecision.noop()

diff --git a/packages/api/src/moderation/util.ts b/packages/api/src/moderation/util.ts
@@ -1,8 +1,4 @@
-import {
-  AppBskyEmbedRecord,
-  AppBskyEmbedRecordWithMedia,
-  AppBskyFeedPost,
-} from '../client'
+import { AppBskyEmbedRecord, AppBskyEmbedRecordWithMedia } from '../client'
 import { ModerationDecision, ModerationUI } from './types'
 
 export function takeHighestPriorityDecision(

diff --git a/packages/api/src/rich-text/sanitization.ts b/packages/api/src/rich-text/sanitization.ts
@@ -1,6 +1,8 @@
 import { RichText } from './rich-text'
 import { UnicodeString } from './unicode'
 
+// this regex is intentionally matching on the zero-with-separator codepoint
+// eslint-disable-next-line no-misleading-character-class
 const EXCESS_SPACE_RE = /[\r\n]([\u00AD\u2060\u200D\u200C\u200B\s]*[\r\n]){2,}/
 const REPLACEMENT_STR = '\n\n'
 

diff --git a/packages/api/tests/bsky-agent.test.ts b/packages/api/tests/bsky-agent.test.ts
@@ -67,7 +67,7 @@ describe('agent', () => {
 
     let hasConflicted = false
     let ranTwice = false
-    await agent.upsertProfile(async (existing) => {
+    await agent.upsertProfile(async (_existing) => {
       if (!hasConflicted) {
         await agent.com.atproto.repo.putRecord({
           repo: agent.session?.did || '',
@@ -104,7 +104,7 @@ describe('agent', () => {
     const profile1 = await agent.getProfile({ actor: agent.session?.did || '' })
     expect(profile1.data.displayName).toBeFalsy()
 
-    const p = agent.upsertProfile(async (existing) => {
+    const p = agent.upsertProfile(async (_existing) => {
       await agent.com.atproto.repo.putRecord({
         repo: agent.session?.did || '',
         collection: 'app.bsky.actor.profile',
@@ -130,7 +130,7 @@ describe('agent', () => {
       password: 'password',
     })
 
-    const p = agent.upsertProfile((existing) => {
+    const p = agent.upsertProfile((_existing) => {
       return {
         displayName: { string: 'Bob' },
       } as unknown as AppBskyActorProfile.Record

diff --git a/packages/bsky/src/api/com/atproto/admin/reverseModerationAction.ts b/packages/bsky/src/api/com/atproto/admin/reverseModerationAction.ts
@@ -1,4 +1,3 @@
-import { AtUri } from '@atproto/syntax'
 import { AuthRequiredError, InvalidRequestError } from '@atproto/xrpc-server'
 import {
   ACKNOWLEDGE,

diff --git a/packages/bsky/tests/seeds/client.ts b/packages/bsky/tests/seeds/client.ts
@@ -9,7 +9,6 @@ import { InputSchema as CreateReportInput } from '@atproto/api/src/client/types/
 import { Record as PostRecord } from '@atproto/api/src/client/types/app/bsky/feed/post'
 import { Record as LikeRecord } from '@atproto/api/src/client/types/app/bsky/feed/like'
 import { Record as FollowRecord } from '@atproto/api/src/client/types/app/bsky/graph/follow'
-import { Record as ListRecord } from '@atproto/api/src/client/types/app/bsky/graph/list'
 
 // Makes it simple to create data via the XRPC client,
 // and keeps track of all created data in memory for convenience.

diff --git a/packages/bsky/tests/views/actor-likes.test.ts b/packages/bsky/tests/views/actor-likes.test.ts
@@ -2,10 +2,6 @@ import AtpAgent, { AtUri } from '@atproto/api'
 import { TestNetwork } from '@atproto/dev-env'
 import { SeedClient } from '../seeds/client'
 import basicSeed from '../seeds/basic'
-import {
-  BlockedByActorError,
-  BlockedActorError,
-} from '@atproto/api/src/client/types/app/bsky/feed/getActorLikes'
 
 describe('bsky actor likes feed views', () => {
   let network: TestNetwork
@@ -17,7 +13,6 @@ describe('bsky actor likes feed views', () => {
   let alice: string
   let bob: string
   let carol: string
-  let dan: string
 
   beforeAll(async () => {
     network = await TestNetwork.create({
@@ -31,7 +26,6 @@ describe('bsky actor likes feed views', () => {
     alice = sc.dids.alice
     bob = sc.dids.bob
     carol = sc.dids.carol
-    dan = sc.dids.dan
   })
 
   afterAll(async () => {

diff --git a/packages/common/tests/streams.test.ts b/packages/common/tests/streams.test.ts
@@ -1,5 +1,5 @@
 import * as streams from '../src/streams'
-import { PassThrough, Readable, pipeline } from 'node:stream'
+import { PassThrough, Readable } from 'node:stream'
 
 describe('streams', () => {
   describe('forwardStreamErrors', () => {

diff --git a/packages/crypto/tests/signatures.test.ts b/packages/crypto/tests/signatures.test.ts
@@ -59,6 +59,7 @@ describe('signatures', () => {
   })
 })
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 async function generateTestVectors(): Promise<TestVector[]> {
   const p256Key = await EcdsaKeypair.create({ exportable: true })
   const secpKey = await Secp256k1Keypair.create({ exportable: true })

diff --git a/packages/lexicon/tests/general.test.ts b/packages/lexicon/tests/general.test.ts
@@ -1,6 +1,5 @@
 import { CID } from 'multiformats/cid'
 import { lexiconDoc, Lexicons } from '../src/index'
-import { object } from '../src/validators/complex'
 import LexiconDocs from './_scaffolds/lexicons'
 
 describe('Lexicons collection', () => {

diff --git a/packages/pds/src/app-view/services/label/index.ts b/packages/pds/src/app-view/services/label/index.ts
@@ -1,5 +1,4 @@
 import { sql } from 'kysely'
-import { CID } from 'multiformats/cid'
 import { AtUri } from '@atproto/syntax'
 import Database from '../../../db'
 import {

diff --git a/packages/pds/src/feed-gen/with-friends.ts b/packages/pds/src/feed-gen/with-friends.ts
@@ -1,16 +1,11 @@
 import AppContext from '../context'
 import { QueryParams as SkeletonParams } from '../lexicon/types/app/bsky/feed/getFeedSkeleton'
-import { paginate } from '../db/pagination'
 import { AlgoHandler, AlgoResponse } from './types'
-import {
-  FeedKeyset,
-  getFeedDateThreshold,
-} from '../app-view/api/app/bsky/util/feed'
 
 const handler: AlgoHandler = async (
-  ctx: AppContext,
-  params: SkeletonParams,
-  requester: string,
+  _ctx: AppContext,
+  _params: SkeletonParams,
+  _requester: string,
 ): Promise<AlgoResponse> => {
   // Temporary change to only return a post notifying users that the feed is down
   return {

diff --git a/packages/pds/src/services/moderation/views.ts b/packages/pds/src/services/moderation/views.ts
@@ -23,7 +23,6 @@ import { AccountService } from '../account'
 import { RecordService } from '../record'
 import { ModerationReportRowWithHandle } from '.'
 import { getSelfLabels } from '../../app-view/services/label'
-import { jsonStringToLex } from '@atproto/lexicon'
 
 export class ModerationViews {
   constructor(private db: Database, private messageDispatcher: MessageQueue) {}

diff --git a/packages/pds/tests/views/actor-likes.test.ts b/packages/pds/tests/views/actor-likes.test.ts
@@ -12,7 +12,6 @@ describe('pds actor likes feed views', () => {
   let alice: string
   let bob: string
   let carol: string
-  let dan: string
 
   beforeAll(async () => {
     const server = await runTestServer({
@@ -25,7 +24,6 @@ describe('pds actor likes feed views', () => {
     alice = sc.dids.alice
     bob = sc.dids.bob
     carol = sc.dids.carol
-    dan = sc.dids.dan
     await server.processAll()
   })
 

diff --git a/packages/repo/tests/util.test.ts b/packages/repo/tests/util.test.ts
@@ -11,7 +11,7 @@ describe('Utils', () => {
           await car.put(block)
           throw new Error('Oops!')
         })
-        for await (const bytes of iter) {
+        for await (const _bytes of iter) {
           // no-op
         }
       }