Skip to content

Commit

Permalink
s3: modules: vfs_default: Remove CHMOD_ACL in chmod.
Browse files Browse the repository at this point in the history
Now I understand the use of the mask in POSIX ACLs
this extra step is no longer needed.

Signed-off-by: Jeremy Allison <[email protected]>
Reviewed-by: Volker Lendecke <[email protected]>
  • Loading branch information
jrasamba committed May 25, 2018
1 parent 90117f2 commit c5060e1
Showing 1 changed file with 0 additions and 21 deletions.
21 changes: 0 additions & 21 deletions source3/modules/vfs_default.c
Original file line number Diff line number Diff line change
Expand Up @@ -1983,27 +1983,6 @@ static int vfswrap_chmod(vfs_handle_struct *handle,
int result;

START_PROFILE(syscall_chmod);

/*
* We need to do this due to the fact that the default POSIX ACL
* chmod modifies the ACL *mask* for the group owner, not the
* group owner bits directly. JRA.
*/


{
int saved_errno = errno; /* We might get ENOSYS */
result = SMB_VFS_CHMOD_ACL(handle->conn,
smb_fname,
mode);
if (result == 0) {
END_PROFILE(syscall_chmod);
return result;
}
/* Error - return the old errno. */
errno = saved_errno;
}

result = chmod(smb_fname->base_name, mode);
END_PROFILE(syscall_chmod);
return result;
Expand Down

0 comments on commit c5060e1

Please sign in to comment.