2.3.56

kenzik · Apr 17, 2017 · 4759821 · 4759821
1 parent dd3d6c1
commit 4759821
Show file tree

Hide file tree

Showing 11 changed files with 65 additions and 31 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,11 @@
+## 2.3.56 (April 17, 2017)
+- Use `prettier` for JS formatting
+- Add `connect-src` CSP for Chrome for iOS fix
+- Add CSS styles to highlight some HTML content issues
+- Remove default `@extend` for buttons
+- Remove `bfg_do_breadcrumbs()` (Genesis will use Yoast SEO's breadcrumbs when they're enabled)
+- Set `X-Frame-Options: SAMEORIGIN` header
+
 ## 2.3.55 (March 9, 2017)
 - Set default paragraph styles 
 - Remove `font-smoothing`

diff --git a/Gruntfile.js b/Gruntfile.js
@@ -76,6 +76,12 @@ module.exports = function(grunt) {
 			}
 		},
 
+		shell: {
+			prettier: {
+				command: 'prettier --use-tabs --single-quote --parser=flow --write js/**/*.js'
+			}
+		},
+
 		concat: {
 			build: {
 				src: [
@@ -165,6 +171,7 @@ module.exports = function(grunt) {
 	grunt.loadNpmTasks('grunt-contrib-concat');
 	grunt.loadNpmTasks('grunt-contrib-imagemin');
 	grunt.loadNpmTasks('grunt-contrib-jshint');
+	grunt.loadNpmTasks('grunt-shell');
 	grunt.loadNpmTasks('grunt-sass');
 	grunt.loadNpmTasks('grunt-contrib-uglify');
 	grunt.loadNpmTasks('grunt-contrib-watch');
@@ -175,6 +182,6 @@ module.exports = function(grunt) {
 	grunt.loadNpmTasks('grunt-postcss');
 
 	grunt.registerTask('default', ['clean', 'imagemin', 'sass', 'concat', 'postcss:css', 'watch']);
-	grunt.registerTask('build', ['clean', 'imagemin', 'csscomb', 'postcss:scss', 'sass', 'jshint', 'concat', 'uglify', 'postcss:css', 'csso']);
+	grunt.registerTask('build', ['clean', 'imagemin', 'csscomb', 'postcss:scss', 'sass', 'jshint', 'shell', 'concat', 'uglify', 'postcss:css', 'csso']);
 
 };
diff --git a/includes/structure/header.php b/includes/structure/header.php
@@ -41,6 +41,7 @@ function bfg_content_security_policy() {
 	default-src 'none';
 	base-uri 'self';
 	block-all-mixed-content;
+	connect-src 'self';
 	font-src 'self' fonts.gstatic.com;
 	form-action 'self';
 	frame-ancestors 'none';
@@ -56,6 +57,21 @@ function bfg_content_security_policy() {
 
 }
 
+add_action( 'wp', 'bfg_send_frame_options_header' );
+/**
+ * Prevent other sites from embedding this one in an iFrame.
+ *
+ * @since 2.3.56
+ */
+function bfg_send_frame_options_header() {
+
+	if( is_admin() )
+		return;
+
+	send_frame_options_header();
+
+}
+
 remove_action( 'genesis_doctype', 'genesis_do_doctype' );
 add_action( 'genesis_doctype', 'bfg_do_doctype' );
 /**

diff --git a/includes/structure/loops.php b/includes/structure/loops.php
@@ -1,20 +1,3 @@
 <?php
 
 if( !defined( 'ABSPATH' ) ) exit; // Exit if accessed directly
-
-remove_action( 'genesis_before_loop', 'genesis_do_breadcrumbs' );
-add_action( 'genesis_before_loop', 'bfg_do_breadcrumbs' );
-/*
- * Use WordPress SEO's breadcrumbs when available
- *
- * @since 2.3.11
- */
-function bfg_do_breadcrumbs() {
-
-	if( function_exists('yoast_breadcrumb') ) {
-		yoast_breadcrumb( '<p class="breadcrumbs">', '</p>' );
-	} else {
-		genesis_do_breadcrumbs();
-	}
-
-}
diff --git a/js/admin.js b/js/admin.js
@@ -1,5 +1,3 @@
 (function() {
-
 	'use strict';
-
 })();
diff --git a/js/scripts.js b/js/scripts.js
@@ -1,11 +1,9 @@
 (function() {
-
 	'use strict';
 
 	// Remove the 'no-js' <body> class
 	document.body.classList.remove('no-js');
 
 	// Enable FitVids on the content area
 	fitvids('.content');
-
 })();
diff --git a/package.json b/package.json
@@ -15,6 +15,7 @@
     "grunt-notify": "*",
     "grunt-postcss": "*",
     "grunt-sass": "*",
+    "grunt-shell": "*",
     "postcss-assets": "*",
     "postcss-color-rgba-fallback": "*",
     "postcss-flexbugs-fixes": "*",
@@ -23,6 +24,7 @@
     "postcss-import": "*",
     "postcss-line-height-px-to-unitless": "*",
     "postcss-scss": "*",
-    "postcss-will-change": "*"
+    "postcss-will-change": "*",
+    "prettier": "*"
   }
 }
diff --git a/sass/_developer-tools.scss b/sass/_developer-tools.scss
@@ -0,0 +1,25 @@
+// https://bitsofco.de/linting-html-using-css/
+
+// Inline styles
+*[style] {
+	border: .5em solid $red;
+}
+
+// Missing <a> hrefs
+a:not([href]),
+a[href='#'],
+a[href=''] {
+	border: .5em solid $red;
+}
+
+// Missing <img> alts
+img:not([alt]),
+img[alt=''] {
+	border: .5em solid $red;
+}
+
+// Empty interactive elements
+button:empty,
+a:empty {
+	border: .5em solid $red;
+}
diff --git a/sass/_forms.scss b/sass/_forms.scss
@@ -42,13 +42,6 @@ select {
 	text-overflow: ellipsis;
 }
 
-button,
-input[type='button'],
-input[type='reset'],
-input[type='submit'] {
-	@extend .btn;
-}
-
 input[type='search'] {
 	box-sizing: border-box; // Overrides normalize.css
 

diff --git a/sass/_toolkit.scss b/sass/_toolkit.scss
@@ -1,4 +1,4 @@
-// Use with @extend to make reponsive modules
+// Use with @include to make reponsive modules
 @mixin wrap {
 	margin: 0 auto;
 	padding-right: .5em;
@@ -21,6 +21,7 @@
 }
 
 @mixin unstyled-list {
+	overflow: initial;
 	margin: 0;
 	padding: 0;
 	list-style: none;

diff --git a/sass/style.scss b/sass/style.scss
@@ -10,6 +10,9 @@
 @import 'variables';
 @import '../bower_components/include-media-export/dist/_include-media-export';
 
+// Development helper styles - should be removed for production
+@import 'developer-tools';
+
 // Clearfix & Toolkit
 @import 'clearfix';
 @import 'toolkit';