Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move jenkins auth settings to separate YAML #16

Merged
merged 1 commit into from
May 20, 2020

Conversation

mattface
Copy link

With the jenkins auth config in the main jenkins.yaml, it's impossible to override this to use a different authentication method.
Instead, move the auth into a seperate yaml file which can be overwritten/deleted by other deployments to use LDAP/github etc.

With the jenkins auth config in the main jenkins.yaml, it's impossible to override this to use a different authentication method.
Instead, move the auth into a seperate yaml file which can be overwritten/deleted by other deployments to use LDAP/github etc.
@mattface mattface requested a review from a team May 11, 2020 16:58
@mattface
Copy link
Author

If this is accepted, it will presumably need a corresponding change in kernelci-jenkins-data, but I can't make that yet as haven't got my gpg key added to the repo.

@gctucker
Copy link
Contributor

The files in the config directory aren't used anywhere on (staging.)kernelci.org, they are leftovers from the original setup which wasn't encrypted. In fact, they can't really be used as they are bound to be different for each Jenkins instance so can't be committed in git.

So they are reference files, a starting point for someone setting up a new instance. It's a good idea anyway to improve them and if splitting the files helps with this then fine.

@mattface
Copy link
Author

mattface commented May 11, 2020

Yes this keeps the reference working with local login with an admin password, but lets it be overridden for production use cases, without having to replace the whole jenkins.yaml file

@gctucker
Copy link
Contributor

OK this is fine. The documentation should be updated now as the config seems to be stable.

@gctucker gctucker merged commit 557ab94 into kernelci:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants