Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHROMEOS timeout increase, dev mapping, early uid diagnostics #77

Conversation

nuclearcat
Copy link
Member

@nuclearcat nuclearcat commented Mar 4, 2022

Add few commands to troubleshoot possible uid / sudo issues.
Add /dev mapping for SDK losetup use.

Signed-off-by: Denys Fedoryshchenko [email protected]

jobs/rootfs-builder.jpl Show resolved Hide resolved
jobs/rootfs-builder.jpl Outdated Show resolved Hide resolved
@nuclearcat nuclearcat force-pushed the T33610-output-timeout-increase branch 2 times, most recently from 372cb2a to eba342c Compare March 8, 2022 07:19
@gctucker
Copy link
Contributor

gctucker commented Mar 8, 2022

Has this been tested on staging?

@nuclearcat
Copy link
Member Author

I think better i will test latest revision on staging. Even with lower timeout it should be able to complete.

@gctucker
Copy link
Contributor

gctucker commented Mar 8, 2022

OK thanks, please put a comment once that has been tested.

@nuclearcat nuclearcat force-pushed the T33610-output-timeout-increase branch from eba342c to 80300a5 Compare March 17, 2022 12:00
Comment on lines +141 to +149
/* Upload stage not working, as kci_rootfs http(s) upload fails for files >1GB */
/*
stage("Upload") {
timeout(time: 30, unit: 'MINUTES') {
upload(config, pipeline_version, kci_core, rootfs_type, arch);
}
}
}
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe if scp works well enough we could start using it for all the rootfs builds and merge this in main branch for production? Are all the rootfs build jobs storing their artifacts in the same directory now or would this only work with Chrome OS builds?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can still merge this PR on chromeos branch first, I was just wondering if it would be trivial to "upstream" bits of it in main.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe no need to merge, i will just test it in state of separate branch in jenkins, and if it will work well, we can make separate, more clean and proper commit for main.

Copy link
Contributor

@gctucker gctucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes to upload using scp should be in a separate commit. Maybe the /dev one too actually, and we may be able to directly merge that in main as I don't think it would have any side-effects with other rootfs builds jobs (buildroot, debos).

Add few commands to troubleshoot possible uid / sudo issues.
Add /dev mapping for SDK losetup use.

v2: Add comments, remove timeout change (it will move to main)
v3: Add upload over scp

Signed-off-by: Denys Fedoryshchenko <[email protected]>
@nuclearcat nuclearcat force-pushed the T33610-output-timeout-increase branch from 80300a5 to 42e06f7 Compare March 17, 2022 18:31
@nuclearcat
Copy link
Member Author

nuclearcat commented Mar 17, 2022

Ok, i will put for each change (scp, dev) separate commit.
Just will do few more tests on jenkins to see if i can make properly working recipe.

@nuclearcat
Copy link
Member Author

@nuclearcat
Copy link
Member Author

I opened new PR with several commits: #79

@nuclearcat nuclearcat closed this Mar 18, 2022
@nuclearcat nuclearcat deleted the T33610-output-timeout-increase branch April 8, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants