Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHROMEOS Fix building debos, as it required for flashing image #81

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

nuclearcat
Copy link
Member

Diagnostic commands can work only for kernelci/chromiumos docker image

Signed-off-by: Denys Fedoryshchenko [email protected]

Diagnostic commands can work only for kernelci/chromiumos docker image

Signed-off-by: Denys Fedoryshchenko <[email protected]>
@gctucker gctucker requested a review from a team March 23, 2022 16:08
@gctucker
Copy link
Contributor

@mgalka Could you please confirm this works with the debos builds in Jenkins?

It's pretty trivial but Groovy is exceptionally good for writing syntactic errors.

@nuclearcat
Copy link
Member Author

Also i tested https://bot.staging.kernelci.org/job/denysf/job/rootfs-builder-debos/4/console
But will appreciate if @mgalka will test it independently.

@mgalka
Copy link

mgalka commented Mar 28, 2022

@nuclearcat @gctucker
It works fine. I have tried it today in the morning https://bot.staging.kernelci.org/job/chromeos/job/rootfs-builder/8/console

@nuclearcat nuclearcat closed this Apr 8, 2022
@nuclearcat nuclearcat deleted the CHROMEOS-fix-debos branch April 8, 2022 11:58
@gctucker
Copy link
Contributor

@nuclearcat Why was this closed? Is it not an issue any more?

@nuclearcat nuclearcat restored the CHROMEOS-fix-debos branch April 11, 2022 08:38
@nuclearcat
Copy link
Member Author

That was by mistake, i was cleaning branches in my repositories.

@nuclearcat nuclearcat reopened this Apr 11, 2022
@gctucker
Copy link
Contributor

OK thanks. I see @mgalka has tested it but not approved it. Is there anything left to check before we merge can merge it?

@mgalka
Copy link

mgalka commented Apr 11, 2022

OK thanks. I see @mgalka has tested it but not approved it. Is there anything left to check before we merge can merge it?

Nothing more from me.

@gctucker gctucker merged commit 55ed696 into kernelci:chromeos Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants