Skip to content

Commit

Permalink
Fixed bug #71617
Browse files Browse the repository at this point in the history
  • Loading branch information
nikic committed Feb 21, 2016
1 parent 2ecc0c1 commit 0bd64b5
Show file tree
Hide file tree
Showing 3 changed files with 61 additions and 0 deletions.
4 changes: 4 additions & 0 deletions NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ PHP NEWS
- phpdbg:
. Fixed crash when advancing (except step) inside an internal function. (Bob)

- SPL:
. Fixed bug #71617 (private properties lost when unserializing ArrayObject).
(Nikita)

?? Mar 2016 PHP 7.0.4

- Core:
Expand Down
7 changes: 7 additions & 0 deletions Zend/zend_API.c
Original file line number Diff line number Diff line change
Expand Up @@ -1226,8 +1226,15 @@ ZEND_API void object_properties_load(zend_object *object, HashTable *properties)
size_t prop_name_len;
if (zend_unmangle_property_name_ex(key, &class_name, &prop_name, &prop_name_len) == SUCCESS) {
zend_string *pname = zend_string_init(prop_name, prop_name_len, 0);
zend_class_entry *prev_scope = EG(scope);
if (class_name && class_name[0] != '*') {
zend_string *cname = zend_string_init(class_name, strlen(class_name), 0);
EG(scope) = zend_lookup_class(cname);
zend_string_release(cname);
}
property_info = zend_get_property_info(object->ce, pname, 1);
zend_string_release(pname);
EG(scope) = prev_scope;
} else {
property_info = ZEND_WRONG_PROPERTY_INFO;
}
Expand Down
50 changes: 50 additions & 0 deletions ext/spl/tests/bug71617.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
--TEST--
Bug #71617: private properties lost when unserializing ArrayObject
--FILE--
<?php

class Test extends ArrayObject
{

private $name = null;

public function __construct(array $input)
{
parent::__construct($input, ArrayObject::ARRAY_AS_PROPS);
}

public function setName($name)
{
$this->name = $name;
return $this;
}

public function getName()
{
return $this->name;
}
}

$test = new Test(['a' => 'a', 'b' => 'b']);
$test->setName('ok');

$ser = serialize($test);
$unSer = unserialize($ser);

var_dump($unSer->getName());
var_dump($unSer);

?>
--EXPECT--
string(2) "ok"
object(Test)#2 (2) {
["name":"Test":private]=>
string(2) "ok"
["storage":"ArrayObject":private]=>
array(2) {
["a"]=>
string(1) "a"
["b"]=>
string(1) "b"
}
}

0 comments on commit 0bd64b5

Please sign in to comment.