Skip to content

Commit

Permalink
do_sigaction: remove now unneeded recalc_sigpending()
Browse files Browse the repository at this point in the history
With the recent changes, do_sigaction()->recalc_sigpending_and_wake() can
never clear TIF_SIGPENDING. Instead, it can set this flag and wake up the
thread without any reason. Harmless, but unneeded and wastes CPU.

Signed-off-by: Oleg Nesterov <[email protected]>
Acked-by: Roland McGrath <[email protected]>
Cc: Ingo Molnar <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Oleg Nesterov authored and Linus Torvalds committed Oct 17, 2007
1 parent d2ee719 commit 045f902
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion kernel/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -2335,7 +2335,6 @@ int do_sigaction(int sig, struct k_sigaction *act, struct k_sigaction *oact)
rm_from_queue_full(&mask, &t->signal->shared_pending);
do {
rm_from_queue_full(&mask, &t->pending);
recalc_sigpending_and_wake(t);
t = next_thread(t);
} while (t != current);
}
Expand Down

0 comments on commit 045f902

Please sign in to comment.