FS routes cleanup and fix component children key for breadcrumbs #11331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzila
approved these changes
Apr 10, 2018
shared/fs/routes.js
Outdated
| }, | ||
| } | ||
|
|
||
| const _previewRoute = { |
There was a problem hiding this comment.
Since this is only used once, can you embed it directly into _folderRoute?
chrisnojima
approved these changes
Apr 13, 2018
|
Reverting the breadcrumb changes as we don't have it in FilePreview; but will keep the component key fixes. |
songgao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.