For integration tests, copy function logs out of container on shutdow…

…n for debugging purposes (apache#3529)
kezhuw · Feb 7, 2019 · 2bc5c5b · 2bc5c5b
1 parent 3b1dd8c
commit 2bc5c5b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/...gration/src/test/java/org/apache/pulsar/tests/integration/containers/WorkerContainer.java b/...gration/src/test/java/org/apache/pulsar/tests/integration/containers/WorkerContainer.java
@@ -18,6 +18,8 @@
  */
 package org.apache.pulsar.tests.integration.containers;
 
+import org.apache.pulsar.tests.integration.utils.DockerUtils;
+
 /**
  * A pulsar container that runs functions worker.
  */
@@ -35,4 +37,16 @@ public WorkerContainer(String clusterName, String hostname) {
             BROKER_HTTP_PORT,
             "/admin/v2/worker/cluster");
     }
+
+    @Override
+    protected void beforeStop() {
+        super.beforeStop();
+        if (null != containerId) {
+            DockerUtils.dumpContainerDirToTargetCompressed(
+                    getDockerClient(),
+                    containerId,
+                    "/pulsar/logs/functions"
+            );
+        }
+    }
 }
diff --git a/tests/integration/src/test/java/org/apache/pulsar/tests/integration/utils/DockerUtils.java b/tests/integration/src/test/java/org/apache/pulsar/tests/integration/utils/DockerUtils.java
@@ -24,6 +24,7 @@
 import com.github.dockerjava.api.async.ResultCallback;
 import com.github.dockerjava.api.command.InspectContainerResponse;
 import com.github.dockerjava.api.command.InspectExecResponse;
+import com.github.dockerjava.api.exception.NotFoundException;
 import com.github.dockerjava.api.model.ContainerNetwork;
 import com.github.dockerjava.api.model.Frame;
 import com.github.dockerjava.api.model.StreamType;
@@ -140,7 +141,9 @@ public static void dumpContainerDirToTargetCompressed(DockerClient dockerClient,
                 read = dockerStream.read(block, 0, READ_BLOCK_SIZE);
             }
         } catch (RuntimeException|IOException e) {
-            LOG.error("Error reading dir from container {}", containerName, e);
+            if (!(e instanceof NotFoundException)) {
+                LOG.error("Error reading dir from container {}", containerName, e);
+            }
         }
     }