fixed token capture logic for tokens with expiry set to 0 #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmagyar
changed the title
michaelmagyar
force-pushed
the
token-capture-fix
branch
from
f97fd2e to
b6db209
Compare
kgretzky
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new logic to avoid capturing empty or expired cookies was missing the case where the cookie expiry is set to 0 (cookie to be deleted by browser on exit). That is a common value for session tokens and is used by GitHub, Office 365, etc., so the existing logic broke token capture for those phishlets.
This pull request fixes the logic such that:
This is accomplished by checking for cookies that are set to zero expiry and allowing them. If they are not zero, then the expiry must be in the future.