reintroduce a few Cows

examples/basic.rs

@@ -22,7 +22,7 @@ async fn main() {
     users.push(config.user_id.into());
     users.push("SwiftOnSecurity".into());
 
-    for user in user::lookup(&users, &config.token)
+    for user in user::lookup(users, &config.token)
         .await
         .unwrap()
         .response

examples/conversations.rs

@@ -12,7 +12,7 @@ async fn main() {
     let convos = convos.newest().await.unwrap();
 
     for (id, convo) in &convos.conversations {
-        let user = egg_mode::user::show(id, &c.token).await.unwrap();
+        let user = egg_mode::user::show(*id, &c.token).await.unwrap();
         println!("-----");
         println!("Conversation with @{}:", user.screen_name);
         for msg in convo {

examples/lists.rs

@@ -12,7 +12,7 @@ async fn main() {
 
     println!("Lists curated by user @Scobleizer:");
     let lists = list::list("Scobleizer", true, &config.token).await.unwrap();
-    for list in lists {
+    for list in lists.iter() {
         if list.user.screen_name == "Scobleizer" {
             println!("    {} ({})", list.name, list.slug);
         }

examples/reciprocal.rs

@@ -18,13 +18,10 @@ async fn main() {
 
     println!("");
     let mut friends = HashSet::new();
-    user::friends_ids(config.user_id, &config.token)
+    let mut friends: HashSet<u64> = user::friends_ids(config.user_id, &config.token)
         .map(|r| r.unwrap().response)
-        .for_each(|id| {
-            friends.insert(id);
-            future::ready(())
-        })
-        .await;
+        .await
+        .collect();
 
     let mut followers = HashSet::new();
     user::followers_ids(config.user_id, &config.token)
@@ -46,7 +43,11 @@ async fn main() {
     );
 
     if reciprocals_ct > 0 {
-        for user in user::lookup(&reciprocals, &config.token).await.unwrap() {
+        for user in user::lookup(reciprocals, &config.token)
+            .await
+            .unwrap()
+            .iter()
+        {
             println!("{} (@{})", user.name, user.screen_name);
         }
     }

examples/tweets.rs

@@ -31,7 +31,7 @@ async fn main() {
     println!("Loading the user's home timeline:");
     let home = egg_mode::tweet::home_timeline(&config.token).with_page_size(5);
     let (_home, feed) = home.start().await.unwrap();
-    for status in feed {
+    for status in feed.iter() {
         common::print_tweet(&status);
         println!("");
     }
@@ -40,7 +40,7 @@ async fn main() {
     println!("Loading the user's mentions timeline:");
     let mentions = egg_mode::tweet::mentions_timeline(&config.token).with_page_size(5);
     let (_mentions, feed) = mentions.start().await.unwrap();
-    for status in feed {
+    for status in feed.iter() {
         common::print_tweet(&status);
         println!("");
     }
@@ -50,7 +50,7 @@ async fn main() {
     let user =
         egg_mode::tweet::user_timeline(config.user_id, true, true, &config.token).with_page_size(5);
     let (_user, feed) = user.start().await.unwrap();
-    for status in feed {
+    for status in feed.iter() {
         common::print_tweet(&status);
         println!("");
     }

src/common/response.rs

@@ -21,7 +21,6 @@ use serde_json;
 
 use std::convert::TryFrom;
 use std::future::Future;
-use std::ops::{Deref, DerefMut};
 use std::pin::Pin;
 use std::task::{Context, Poll};
 use std::{io, mem};
@@ -63,11 +62,15 @@ fn rate_limit_reset(headers: &Headers) -> Result<Option<i32>> {
 ///
 ///As this implements `Deref` and `DerefMut`, you can transparently use the contained `response`'s
 ///methods as if they were methods on this struct.
-#[derive(Debug, Deserialize, derive_more::Constructor)]
+#[derive(
+    Debug, Deserialize, derive_more::Constructor, derive_more::Deref, derive_more::DerefMut,
+)]
 pub struct Response<T> {
     /// Latest rate lime status
     pub rate_limit_status: RateLimit,
     ///The decoded response from the request.
+    #[deref]
+    #[deref_mut]
     pub response: T,
 }
 
@@ -97,20 +100,6 @@ impl<T> Response<T> {
     }
 }
 
-impl<T> Deref for Response<T> {
-    type Target = T;
-
-    fn deref(&self) -> &Self::Target {
-        &self.response
-    }
-}
-
-impl<T> DerefMut for Response<T> {
-    fn deref_mut(&mut self) -> &mut Self::Target {
-        &mut self.response
-    }
-}
-
 pub fn get_response(request: Request<Body>) -> ResponseFuture {
     // TODO: num-cpus?
     let connector = HttpsConnector::new();

src/cursor.rs

@@ -254,7 +254,7 @@ where
     ///implementation. It is made available for those who wish to manually manage network calls and
     ///pagination.
     pub next_cursor: i64,
-    loader: Option<Pin<Box<dyn Future<Output = Result<Response<T>>>>>>,
+    loader: Option<FutureResponse<T>>,
     iter: Option<VecIter<T::Item>>,
 }
 

src/list/mod.rs

@@ -109,8 +109,8 @@ pub enum ListID {
 
 impl ListID {
     ///Make a new `ListID` by supplying its owner and name.
-    pub fn from_slug<T: Into<user::UserID>>(owner: T, list_name: CowStr) -> ListID {
-        ListID::Slug(owner.into(), list_name)
+    pub fn from_slug<T: Into<user::UserID>>(owner: T, list_name: impl Into<CowStr>) -> ListID {
+        ListID::Slug(owner.into(), list_name.into())
     }
 
     ///Make a new `ListID` by supplying its numeric ID.

src/media/mod.rs

@@ -171,7 +171,6 @@ impl MediaHandle {
     /// Returns whether media is still valid to be used in API calls.
     ///
     /// Under hood it is `Instant::now() < handle.valid_until`.
-    #[inline]
     pub fn is_valid(&self) -> bool {
         Instant::now() < self.valid_until
     }

src/place/fun.rs

@@ -129,13 +129,13 @@ pub fn search_point(latitude: f64, longitude: f64) -> SearchBuilder {
 /// assert!(result.results.iter().any(|pl| pl.full_name == "British Columbia, Canada"));
 /// # }
 /// ```
-pub fn search_query(query: String) -> SearchBuilder {
-    SearchBuilder::new(PlaceQuery::Query(query))
+pub fn search_query(query: impl Into<CowStr>) -> SearchBuilder {
+    SearchBuilder::new(PlaceQuery::Query(query.into()))
 }
 
 ///Begins building a location search via an IP address.
-pub fn search_ip(query: String) -> SearchBuilder {
-    SearchBuilder::new(PlaceQuery::IPAddress(query))
+pub fn search_ip(query: impl Into<CowStr>) -> SearchBuilder {
+    SearchBuilder::new(PlaceQuery::IPAddress(query.into()))
 }
 
 ///From a URL given with the result of any `search_*` function, perform the same location search.

src/place/mod.rs

@@ -211,8 +211,8 @@ impl GeocodeBuilder {
 
 enum PlaceQuery {
     LatLon(f64, f64),
-    Query(String),
-    IPAddress(String),
+    Query(CowStr),
+    IPAddress(CowStr),
 }
 
 ///Represents a location search query before it is sent.

src/tweet/mod.rs

@@ -604,7 +604,7 @@ impl Timeline {
 #[must_use = "futures do nothing unless polled"]
 pub struct TimelineFuture {
     timeline: Option<Timeline>,
-    loader: Pin<Box<dyn Future<Output = Result<Response<Vec<Tweet>>>>>>,
+    loader: FutureResponse<Vec<Tweet>>,
 }
 
 impl Future for TimelineFuture {

src/user/mod.rs

@@ -479,8 +479,7 @@ pub struct UserSearch {
     pub page_num: i32,
     /// The number of user records per page of results. Defaults to 10, maximum of 20.
     pub page_size: i32,
-    current_loader:
-        Option<Pin<Box<dyn Future<Output = error::Result<Response<Vec<TwitterUser>>>>>>>,
+    current_loader: Option<FutureResponse<Vec<TwitterUser>>>,
     current_results: Option<VecIter<TwitterUser>>,
 }