Skip to content

Commit

Permalink
minSDK in manifest errors the compilation. Fixed (react-native-maps#2472
Browse files Browse the repository at this point in the history
)

* Fixed compiling with minSDK in manifest file error

When upgrading to newer gradle wrapper package versions that works with buildtools version 28+, error comes up if uses-sdk tag has "minSDK" property defined inside AndroidMainfest.xml file. Default SDK properties should stand only inside build.gradle files.

* Rename mainAndroidManifest.xml to AndroidManifest.xml

* Rename lib/android/src/AndroidManifest.xml to lib/android/src/main/AndroidManifest.xml
  • Loading branch information
dkfl1995 authored and rborn committed Sep 7, 2018
1 parent 108bf75 commit 680debe
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion lib/android/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.airbnb.android.react.maps" >
<uses-sdk android:minSdkVersion="16" />
<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
</manifest>

0 comments on commit 680debe

Please sign in to comment.