Make WarmUpRateLimiterControllerTest stable

kingzuo · Apr 12, 2019 · 16082a8 · 16082a8
1 parent aaeeea3
commit 16082a8
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/...com/alibaba/csp/sentinel/slots/block/flow/controller/WarmUpRateLimiterControllerTest.java b/...com/alibaba/csp/sentinel/slots/block/flow/controller/WarmUpRateLimiterControllerTest.java
@@ -27,10 +27,14 @@ public void testPace() throws InterruptedException {
 
         assertTrue(controller.canPass(node, 1));
 
+        // Easily fail in single request testing, so we increase it to 10 requests and test the average time
         long start = System.currentTimeMillis();
-        assertTrue(controller.canPass(node, 1));
-        long cost = System.currentTimeMillis() - start;
-        assertTrue(cost >= 100 && cost <= 120);
+        int requests = 10;
+        for (int i = 0; i < requests; i++) {
+            assertTrue(controller.canPass(node, 1));
+        }
+        float cost = (System.currentTimeMillis() - start) / 1.0f / requests;
+        assertTrue(Math.abs(cost - 100) < 10);
     }
 
     @Test