Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

packer: fix ansible_os_family and iso_checksum #5

Merged
merged 0 commits into from
Jul 16, 2020

Conversation

dongsupark
Copy link
Member

@dongsupark dongsupark commented Jul 13, 2020

It has not been possible to create images for other distros like Ubuntu 1804, because our Flatcar PR started to specify ansible_os_family in packer/config/ansible-args.json.
It means, it is not able to get the OS family recognized by Ansible.
We need to manually specify ansible_os_family in each distro-specific config.

Now that iso_checksum is composed of iso_checksum_type:iso_checksum_value, we need to change the format of iso_checksum in Flatcar.
Since the value relies on the format of file:https://..., we need to move the type part file into a new field iso_checksum_type, which is now required by packer/qemu/packer.json. Then we do not need to keep the prefix file: in iso_checksum.

@dongsupark dongsupark added the kind/bug Something isn't working label Jul 13, 2020
@dongsupark
Copy link
Member Author

Now the upstream image-builder has changed code around goss.
Rebasing the whole tree on top of master is not trivial. Fun.
Will soon the rebase and tests together with this PR.

@dongsupark dongsupark force-pushed the dongsu/capi-flatcar-20200713 branch from 9fdf3fc to 1b51d2f Compare July 15, 2020 10:16
@dongsupark dongsupark changed the title [WIP] packer: explicitly set ansible_os_family etc. 20200713 packer: explicitly set ansible_os_family etc. 20200713 Jul 15, 2020
@dongsupark dongsupark force-pushed the dongsu/capi-flatcar branch from f4d422c to 0d75fdd Compare July 15, 2020 10:19
@dongsupark dongsupark changed the title packer: explicitly set ansible_os_family etc. 20200713 packer: fix ansible_os_family and iso_checksum Jul 15, 2020
@dongsupark dongsupark requested review from t-lo and vbatts July 15, 2020 10:21
@dongsupark dongsupark marked this pull request as ready for review July 15, 2020 10:21
@dongsupark
Copy link
Member Author

Ready for review.

Pushed also fixes for the iso_checksum issue.

Note, the commit capi: remove iso_checksum_type in qemu for packer 1.6 is already created as a separate PR to upstream, kubernetes-sigs#289. So after the PR got merged by upstream, we will delete the commit.

@dongsupark dongsupark force-pushed the dongsu/capi-flatcar-20200713 branch from 1b51d2f to 1b34f45 Compare July 16, 2020 07:57
@dongsupark
Copy link
Member Author

Note, the commit capi: remove iso_checksum_type in qemu for packer 1.6 is already created as a separate PR to upstream, kubernetes-sigs#289. So after the PR got merged by upstream, we will delete the commit.

Now that the PR kubernetes-sigs#289 was merged, I dropped the commit capi: remove iso_checksum_type in qemu for packer 1.6.
Tested again. It works.

@dongsupark dongsupark merged commit 1b34f45 into dongsu/capi-flatcar Jul 16, 2020
@dongsupark dongsupark force-pushed the dongsu/capi-flatcar branch from 0d75fdd to 1b34f45 Compare July 16, 2020 08:01
@dongsupark
Copy link
Member Author

Merged to kubernetes-sigs#248.

@dongsupark dongsupark deleted the dongsu/capi-flatcar-20200713 branch July 16, 2020 08:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant