Skip to content

Commit

Permalink
- fix issue 1125 where chat box is hidden because of scolling on a Mac
Browse files Browse the repository at this point in the history
  • Loading branch information
@ritzalam
ritzalam committed Mar 6, 2012
1 parent 9a35326 commit fad4a7d
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions bigbluebutton-client/src/org/bigbluebutton/modules/chat/views/ChatBox.mxml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,7 @@
private function scrollToBottom():void {
chatMessagesList.invalidateSize();
chatMessagesList.invalidateDisplayList();
chatMessagesList.scrollToIndex(messages.length);
chatMessagesList.verticalScrollPosition = chatMessagesList.maxVerticalScrollPosition;
chatMessagesList.scrollToIndex(messages.length);
chatMessagesList.validateDisplayList();
chatMessagesList.validateNow();
}
Expand Down

8 comments on commit fad4a7d

@kirill-scherba
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It not fixed...

@ritzalam
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please elaborate? What version of Mac and please attach a screenshot on the issue tracker.

But first, can you please clear your cache and test agian?

Thanks.

@kirill-scherba
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. After cleaning cache it works properly.

@kirill-scherba
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was tested under Mac OS X 10.7.3 in Google Chrome 17.0.963.66

@ritzalam
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed another fix. Can you please try again and let us know if it works for you too?

bigbluebutton@b17cf9a

@kirill-scherba
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it works properly under MAC OS under Google Chrome. All three windows in main window looks correct.

  • I can't start bbb client under MAC OS Safari browser - it needs Adobe Flash player 1.1 & can't download it (I think it some MAC OS or Safari baf). I'll try to show it later.
  • And I know one more BBBs bug (not this ticket bug): I can't start Share My Desktop under Linux Gnome under Chrome browser (it don't starts Desktop Region window) but it works correctly under Mozila at the same system. I have tested it in to different Linux with Chrome installed.

@kirill-scherba
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not so good as I told in my previous message:

I have reinstall my Flash Player & now Chat Window has wrong width and wrong start horizontal position. The chat window is wider then needed and is displayed on presentation window (how to add screenshots here?). It runs under Chrome & Safari browsers (at mac os).

@kirill-scherba
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O! I see when the width & position of chat window is wrong it don't depends of Flash Player. It depends of browsers width. :)
If my browsers width is full - the chats window looks good, if browser is half of it width the chats window is wider then need & displayed under presentation window.

Please sign in to comment.