Skip to content

Commit

Permalink
Add a disabled test for accessing private attributes of other objects
Browse files Browse the repository at this point in the history
Need to cleanup the code before we can enable this test.
  • Loading branch information
abadger committed Nov 10, 2015
1 parent 5661444 commit 74fe9d2
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions test/code-smell/inappropriately-private.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#!/bin/sh

#
# Test that we do not access private attributes of other objects.
#
# * private attributes of ourself are okay: self._private.
# * Private attributes of other objects are not: self.other._private
#

# Currently the code has many places where we're violating this test so we need
# to clean up the code before we can enable this. Maybe we'll need to
# selectively blacklist modules so that we can work on this a piece at a time.
#
# Also need to implement whitelist for certain things like bundled libraries
# that violate this.
#
# 23-10-2015: Count was 508 lines
grep -Pri '(?<!self)\._(?!_)' $1|grep -v modules

0 comments on commit 74fe9d2

Please sign in to comment.