Skip to content

Commit

Permalink
src/goTools: install [email protected] when building with go1.18
Browse files Browse the repository at this point in the history
[email protected].* requires go1.19+.

Change-Id: I1299b276f8c39fc7ea6f38a0ddf9ba3108ca759f
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/470475
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Suzy Mueller <[email protected]>
TryBot-Result: kokoro <[email protected]>
(cherry picked from commit d7419f4)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/470636
Run-TryBot: Suzy Mueller <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
  • Loading branch information
hyangah authored and suzmue committed Feb 23, 2023
1 parent 17494ce commit 170d3dc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/goTools.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export function getImportPathWithVersion(
}
if (tool.name === 'staticcheck') {
if (goVersion.lt('1.17')) return importPath + '@v0.2.2';
if (goVersion.lt('1.18')) return importPath + '@v0.3.3';
if (goVersion.lt('1.19')) return importPath + '@v0.3.3';
}
if (tool.name === 'gofumpt') {
if (goVersion.lt('1.18')) return importPath + '@v0.2.1';
Expand Down
2 changes: 1 addition & 1 deletion tools/installtools/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ var tools = []struct {
{"github.com/sqs/goreturns", "", false, nil},
{"github.com/uudashr/gopkgs/v2/cmd/gopkgs", "", false, nil},
{"github.com/zmb3/gogetdoc", "", false, nil},
{"honnef.co/go/tools/cmd/staticcheck", "", false, []finalVersion{{16, "v0.2.2"}, {17, "v0.3.3"}}},
{"honnef.co/go/tools/cmd/staticcheck", "", false, []finalVersion{{16, "v0.2.2"}, {18, "v0.3.3"}}},
{"golang.org/x/tools/cmd/gorename", "", false, nil},
{"github.com/go-delve/delve/cmd/dlv", "", false, []finalVersion{{16, "v1.8.3"}, {17, "v1.9.1"}}},
}
Expand Down

0 comments on commit 170d3dc

Please sign in to comment.