forked from fullstorydev/grpcui
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from fullstorydev:master #12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [github.com/jhump/protoreflect](https://github.com/jhump/protoreflect) from 1.15.3 to 1.15.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/jhump/protoreflect/releases">github.com/jhump/protoreflect's releases</a>.</em></p> <blockquote> <h2>v1.15.4</h2> <p>This is a bugfix release to address bugs in the <code>desc/protoprint</code> package and a compatibility issue with the most recent version of <code>github.com/bufbuild/protocompile</code>.</p> <h3>"github.com/jhump/protoreflect/desc/protoparse"</h3> <p>Changes/fixes:</p> <ul> <li>As of v1.15.0, this package uses the <a href="https://pkg.go.dev/github.com/bufbuild/protocompile"><code>github.com/bufbuild/protocompile</code></a> package under the hood as the parser. But that package is still using major version zero, since it's API has not completely stabilized. A recent release (v0.7.0) included backwards-incompatible changes that caused this repo to no longer compile. This release addresses the compile errors: this repo now uses that latest release of <code>protocompile</code> and correctly compiles against it.</li> </ul> <h3>"github.com/jhump/protoreflect/desc/protoprint"</h3> <p>Changes/fixes:</p> <ul> <li>When a string literal included a double-quote character (<code>"</code>), it would get printed incorrectly leading to either an incorrect string literal in some cases or an invalid and uncompilable source file in others. This has been fixed.</li> <li>When sorting elements in the file, if the file used proto3 syntax and had an enum with negative numeric values, the result would include the negative values first, before the zero value. This is not allowed in proto3 syntax, which requires that the zero value be the first value, so the result would be an invalid and uncompilable source file. This has been fixed.</li> <li>When a source file is parsed into a <code>FileDescriptorProto</code> but never linked, the descriptor may be missing the <code>type</code> field of a <code>FieldDescriptorProto</code> (since it is not known whether a named type refers to a message, group, or enum), and it may have options left in the <code>uninterpreted_options</code> field of the various options messages, which has a peculiar representation for aggregate values. When printing a descriptor that had these characteristics, they were not correctly handled, so the output of the printer would be an invalid and uncompilable source file. Both of these cases have been fixed.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/jhump/protoreflect/commit/f139a6debe4ec67cddb8e11df35b8a1934203c68"><code>f139a6d</code></a> update to protocompile v0.7.1; fix some incompatibilities with it (<a href="https://redirect.github.com/jhump/protoreflect/issues/586">#586</a>)</li> <li><a href="https://github.com/jhump/protoreflect/commit/dd8b73728bbd275698f293b06025c6da7e102393"><code>dd8b737</code></a> protoprint: fix handling of uninterpreted options (<a href="https://redirect.github.com/jhump/protoreflect/issues/584">#584</a>)</li> <li><a href="https://github.com/jhump/protoreflect/commit/5d002922aeacb0d8722a22949f986cd31eedd172"><code>5d00292</code></a> protoprint: when sorting elements, first value must be zero in proto3 file(<a href="https://redirect.github.com/jhump/protoreflect/issues/582">#582</a>)</li> <li><a href="https://github.com/jhump/protoreflect/commit/e429ee6b3537f3d1414fbe2e8352222b41559f96"><code>e429ee6</code></a> protoprint: fix bug in escaping double-quote characters (<a href="https://redirect.github.com/jhump/protoreflect/issues/580">#580</a>)</li> <li><a href="https://github.com/jhump/protoreflect/commit/3839451e1677ae9870ddac6e21dd2db4f3f14a7d"><code>3839451</code></a> build(deps): bump google.golang.org/grpc from 1.57.0 to 1.57.1 (<a href="https://redirect.github.com/jhump/protoreflect/issues/578">#578</a>)</li> <li><a href="https://github.com/jhump/protoreflect/commit/937385c353f3b07ecd5d7fd042afe8b94eddf425"><code>937385c</code></a> build(deps): bump golang.org/x/net from 0.9.0 to 0.17.0 (<a href="https://redirect.github.com/jhump/protoreflect/issues/576">#576</a>)</li> <li><a href="https://github.com/jhump/protoreflect/commit/a4984b210bebde4f7917a896cf18b683b6711c42"><code>a4984b2</code></a> Fix copy+paste errors</li> <li>See full diff in <a href="https://github.com/jhump/protoreflect/compare/v1.15.3...v1.15.4">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/jhump/protoreflect&package-manager=go_modules&previous-version=1.15.3&new-version=1.15.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )