Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from fullstorydev:master #35

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[pull] master from fullstorydev:master #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,8 @@ jobs:
working_directory: ~/repo
docker:
- image: cimg/go:1.21
steps:
- checkout
- run:
name: Run tests and linters
command: |
make ci
steps: *simple_job_steps

# TODO: Need updates to some static analyzer tools to support 1.22.
# After those are updated, move the full linting from 1.21 to this latest release.
build-1-22:
working_directory: ~/repo
docker:
Expand All @@ -32,7 +25,12 @@ jobs:
working_directory: ~/repo
docker:
- image: cimg/go:1.23
steps: *simple_job_steps
steps:
- checkout
- run:
name: Run tests and linters
command: |
make ci

workflows:
pr-build-test:
Expand Down
6 changes: 3 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ ci: deps checkgofmt checkgenerate vet staticcheck ineffassign predeclared test

.PHONY: deps
deps:
go get -d -v -t ./...
go get -v -t ./...
go mod tidy

.PHONY: updatedeps
Expand Down Expand Up @@ -68,7 +68,7 @@ vet:

.PHONY: staticcheck
staticcheck:
@go install honnef.co/go/tools/cmd/staticcheck@v0.4.3
@go install honnef.co/go/tools/cmd/staticcheck@v0.5.1
staticcheck ./...

.PHONY: ineffassign
Expand All @@ -78,7 +78,7 @@ ineffassign:

.PHONY: predeclared
predeclared:
@go install github.com/nishanths/predeclared@5f2f810c9ae6
@go install github.com/nishanths/predeclared@245576f9a85c96ea16c750df3887f1d827f01e9c
predeclared ./...

# Intentionally omitted from CI, but target here for ad-hoc reports.
Expand Down