[pull] master from fullstorydev:master #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This PR disables CGO so we don't have any dependencies on C libraries expected to be found in the environment, in order to achieve a better compatibility across distros. Tested by running `make install` before and after the changes and inspecting the produced binary from a Linux machine (Debian in this case). **Before** ```sh ldd $(which grpcui) linux-vdso.so.1 (0x00007ffe2cb2e000) libresolv.so.2 => /lib/x86_64-linux-gnu/libresolv.so.2 (0x00007fcc13946000) libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fcc13924000) libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fcc13750000) /lib64/ld-linux-x86-64.so.2 (0x00007fcc1396a000) ``` **After** ```sh ldd $(which grpcui) not a dynamic executable ``` Follow-up of the same changes in `grpcurl`: fullstorydev/grpcurl#420
While releasing `[email protected]`, I encountered an error described in fullstorydev/grpcurl#421. A similar change happened in `grpcui`'s Homebrew formula: Homebrew/homebrew-core@c845f04 We probably need to update the Tarball URL used to update our Homebrew formula as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )