Kc 2085 align search pop up usage with design #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasportella
requested changes
Nov 1, 2023
src/components/InputGlobal/index.tsx
Outdated
| } | ||
| setSearch(event.target.value); | ||
| setShowTooltip(true); | ||
| setSearch(event.target.value.trim().toLowerCase()); |
There was a problem hiding this comment.
need to add debounce function
src/components/InputGlobal/index.tsx
Outdated
| @@ -18,6 +18,7 @@ const Input: React.FC<InputGlobal> = ({ | |||
| }) => { | |||
| const [search, setSearch] = useState(''); | |||
| const [error, setError] = useState(false); | |||
| const [linkPage, setLinkPage] = useState(''); | |||
There was a problem hiding this comment.
is there another user action that needs to be monitored besides the text input or mouse focus in/out of the pop up? if not, just create a variable that stores the data you want to save
src/components/InputGlobal/index.tsx
Outdated
| setShowTooltip(true); | ||
| setSearch(event.target.value); |
There was a problem hiding this comment.
this does not solve excessive user requests, must add debounce fn
lucasportella
requested changes
Nov 3, 2023
| @@ -49,14 +49,18 @@ const getRedirectButton = ( | |||
| </div> | |||
| ); | |||
|
|
|||
| export const setSessionStorage = (link: string): void => { | |||
There was a problem hiding this comment.
i'm not very sure if this is really necessary. Let's discuss this in PR time
lucasportella
approved these changes
Nov 16, 2023
Doug-Fernando
approved these changes
Nov 17, 2023
Doug-Fernando
deleted the
KC-2085-align-search-pop-up-usage-with-design
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.