Merge pull request KhronosGroup#1851 from KhronosGroup/fix_1849_round…

…_normals Round normals to avoid vertex split
kllll000 · Feb 11, 2023 · 2ad6c77 · 2ad6c77
2 parents d189049 + b5ef8e0
commit 2ad6c77
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_primitives_extract.py b/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_primitives_extract.py
@@ -17,6 +17,7 @@
 
 from . import gltf2_blender_export_keys
 from ...io.com.gltf2_io_debug import print_console
+from ...io.com.gltf2_io_constants import NORMALS_ROUNDING_DIGIT
 from io_scene_gltf2.blender.exp import gltf2_blender_gather_skins
 from io_scene_gltf2.io.com import gltf2_io_constants
 from io_scene_gltf2.blender.com import gltf2_blender_conversion
@@ -710,10 +711,13 @@ def __get_normals(self):
 
         self.normals = self.normals.reshape(len(self.blender_mesh.loops), 3)
 
+        self.normals = np.round(self.normals, NORMALS_ROUNDING_DIGIT)
+
         self.morph_normals = []
         for key_block in key_blocks:
             ns = np.array(key_block.normals_split_get(), dtype=np.float32)
             ns = ns.reshape(len(self.blender_mesh.loops), 3)
+            ns = np.round(ns, NORMALS_ROUNDING_DIGIT)
             self.morph_normals.append(ns)
 
         # Transform for skinning

diff --git a/addons/io_scene_gltf2/io/com/gltf2_io_constants.py b/addons/io_scene_gltf2/io/com/gltf2_io_constants.py
@@ -161,3 +161,6 @@ class BufferViewTarget(IntEnum):
 GLTF_DATA_TYPE_MAT4 = "MAT4"
 
 GLTF_IOR = 1.5
+
+# Rounding digit used for normal rounding
+NORMALS_ROUNDING_DIGIT = 4