Skip to content

Commit

Permalink
Disable IBCMerge on OSX builds (dotnet#33393)
Browse files Browse the repository at this point in the history
* Disable System.Private.CoreLib IBCMerge on MacOS.

* Disable IBCMerge on mac across the board.

* Update comment to include link to issue.
  • Loading branch information
jkoritzinsky authored Mar 9, 2020
1 parent 8124268 commit 31a65f0
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions eng/codeOptimization.targets
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@
<IsEligibleForNgenOptimization>true</IsEligibleForNgenOptimization>
<IsEligibleForNgenOptimization Condition="'$(IsReferenceAssembly)' == 'true'">false</IsEligibleForNgenOptimization>
<IsEligibleForNgenOptimization Condition="'$(GeneratePlatformNotSupportedAssembly)' == 'true' or '$(GeneratePlatformNotSupportedAssemblyMessage)' != ''">false</IsEligibleForNgenOptimization>
<!-- There's an issue causing IBCMerge failures because of mismatched MVIDs
across many of our assemblies on Mac, so disable
IBCMerge optimizations on Mac for now to unblock the offical build.
See issue https://github.com/dotnet/runtime/issues/33303
-->
<IsEligibleForNgenOptimization Condition="'$(TargetOS)' == 'OSX'">false</IsEligibleForNgenOptimization>
</PropertyGroup>

<Target Name="SetApplyNgenOptimization"
Expand Down

0 comments on commit 31a65f0

Please sign in to comment.