Skip to content

Commit

Permalink
mm/memory_hotplug: cleanup __remove_pages()
Browse files Browse the repository at this point in the history
Let's drop the basically unused section stuff and simplify.

Also, let's use a shorter variant to calculate the number of pages to
the next section boundary.

Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: David Hildenbrand <[email protected]>
Cc: Oscar Salvador <[email protected]>
Cc: Michal Hocko <[email protected]>
Cc: "Matthew Wilcox (Oracle)" <[email protected]>
Cc: "Aneesh Kumar K.V" <[email protected]>
Cc: Pavel Tatashin <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Dan Williams <[email protected]>
Cc: Logan Gunthorpe <[email protected]>
Cc: Pankaj Gupta <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
davidhildenbrand authored and torvalds committed Feb 4, 2020
1 parent 5d12071 commit 52fb87c
Showing 1 changed file with 6 additions and 11 deletions.
17 changes: 6 additions & 11 deletions mm/memory_hotplug.c
Original file line number Diff line number Diff line change
Expand Up @@ -516,25 +516,20 @@ static void __remove_section(unsigned long pfn, unsigned long nr_pages,
void __remove_pages(unsigned long pfn, unsigned long nr_pages,
struct vmem_altmap *altmap)
{
const unsigned long end_pfn = pfn + nr_pages;
unsigned long cur_nr_pages;
unsigned long map_offset = 0;
unsigned long nr, start_sec, end_sec;

map_offset = vmem_altmap_offset(altmap);

if (check_pfn_span(pfn, nr_pages, "remove"))
return;

start_sec = pfn_to_section_nr(pfn);
end_sec = pfn_to_section_nr(pfn + nr_pages - 1);
for (nr = start_sec; nr <= end_sec; nr++) {
unsigned long pfns;

for (; pfn < end_pfn; pfn += cur_nr_pages) {
cond_resched();
pfns = min(nr_pages, PAGES_PER_SECTION
- (pfn & ~PAGE_SECTION_MASK));
__remove_section(pfn, pfns, map_offset, altmap);
pfn += pfns;
nr_pages -= pfns;
/* Select all remaining pages up to the next section boundary */
cur_nr_pages = min(end_pfn - pfn, -(pfn | PAGE_SECTION_MASK));
__remove_section(pfn, cur_nr_pages, map_offset, altmap);
map_offset = 0;
}
}
Expand Down

0 comments on commit 52fb87c

Please sign in to comment.