Skip to content

Commit

Permalink
virtio_balloon: prevent pfn array overflow
Browse files Browse the repository at this point in the history
Make sure, at build time, that pfn array is big enough to hold a single
page.  It happens to be true since the PAGE_SHIFT value at the moment is
20, which is 1M - exactly 256 4K balloon pages.

Signed-off-by: Michael S. Tsirkin <[email protected]>
Reviewed-by: David Hildenbrand <[email protected]>
  • Loading branch information
mstsirkin committed Feb 6, 2020
1 parent 782e067 commit 6e9826e
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/virtio/virtio_balloon.c
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,8 @@ static void set_page_pfns(struct virtio_balloon *vb,
{
unsigned int i;

BUILD_BUG_ON(VIRTIO_BALLOON_PAGES_PER_PAGE > VIRTIO_BALLOON_ARRAY_PFNS_MAX);

/*
* Set balloon pfns pointing at this page.
* Note that the first pfn points at start of the page.
Expand Down

0 comments on commit 6e9826e

Please sign in to comment.