Skip to content

Commit

Permalink
dt-bindings: net: ti: cpsw-switch: update to fix comments
Browse files Browse the repository at this point in the history
After original patch was merged there were additional comments/requests
provided by Rob Herring [1]. Mostly they are related to json-schema usage,
and this patch fixes them. Also SPDX-License-Identifier has been changed to
(GPL-2.0-only OR BSD-2-Clause) as requested.

[1] https://lkml.org/lkml/2019/11/21/875
Fixes: ef63fe7 ("dt-bindings: net: ti: add new cpsw switch driver bindings")
Signed-off-by: Grygorii Strashko <[email protected]>
[robh: Remove 2 more maxItems that aren't necessary]
Signed-off-by: Rob Herring <[email protected]>
  • Loading branch information
grygoriyS authored and robherring committed Dec 11, 2019
1 parent 71bbcd2 commit a2ce321
Showing 1 changed file with 7 additions and 15 deletions.
22 changes: 7 additions & 15 deletions Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SPDX-License-Identifier: GPL-2.0
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
%YAML 1.2
---
$id: http://devicetree.org/schemas/net/ti,cpsw-switch.yaml#
Expand Down Expand Up @@ -44,7 +44,6 @@ properties:
description: CPSW functional clock

clock-names:
maxItems: 1
items:
- const: fck

Expand All @@ -70,7 +69,6 @@ properties:
Phandle to the system control device node which provides access to
efuse IO range with MAC addresses


ethernet-ports:
type: object
properties:
Expand All @@ -82,32 +80,27 @@ properties:
patternProperties:
"^port@[0-9]+$":
type: object
minItems: 1
maxItems: 2
description: CPSW external ports

allOf:
- $ref: ethernet-controller.yaml#

properties:
reg:
maxItems: 1
enum: [1, 2]
items:
- enum: [1, 2]
description: CPSW port number

phys:
$ref: /schemas/types.yaml#definitions/phandle-array
maxItems: 1
description: phandle on phy-gmii-sel PHY

label:
$ref: /schemas/types.yaml#/definitions/string-array
maxItems: 1
description: label associated with this port

ti,dual-emac-pvid:
$ref: /schemas/types.yaml#/definitions/uint32
maxItems: 1
allOf:
- $ref: /schemas/types.yaml#/definitions/uint32
minimum: 1
maximum: 1024
description:
Expand Down Expand Up @@ -136,7 +129,6 @@ properties:
description: CPTS reference clock

clock-names:
maxItems: 1
items:
- const: cpts

Expand Down Expand Up @@ -201,7 +193,7 @@ examples:
phys = <&phy_gmii_sel 1>;
phy-handle = <&ethphy0_sw>;
phy-mode = "rgmii";
ti,dual_emac_pvid = <1>;
ti,dual-emac-pvid = <1>;
};
cpsw_port2: port@2 {
Expand All @@ -211,7 +203,7 @@ examples:
phys = <&phy_gmii_sel 2>;
phy-handle = <&ethphy1_sw>;
phy-mode = "rgmii";
ti,dual_emac_pvid = <2>;
ti,dual-emac-pvid = <2>;
};
};
Expand Down

0 comments on commit a2ce321

Please sign in to comment.