GEODE-2679: Lucene asynchronous disk writes for aeq can lead to data …

…mismatch after compacting * forcing disk sync = true for Lucene AEQ
kmaxself · Mar 20, 2017 · 1787768 · 1787768
1 parent 84a1a9b
commit 1787768
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java
@@ -170,7 +170,7 @@ private AsyncEventQueueFactoryImpl createAEQFactory(final Region dataRegion) {
       factory.setPersistent(true);
     }
     factory.setDiskStoreName(dataRegion.getAttributes().getDiskStoreName());
-    factory.setDiskSynchronous(dataRegion.getAttributes().isDiskSynchronous());
+    factory.setDiskSynchronous(true);
     factory.setForwardExpirationDestroy(true);
     return factory;
   }

diff --git a/...est/java/org/apache/geode/cache/lucene/LuceneIndexCreationPersistenceIntegrationTest.java b/...est/java/org/apache/geode/cache/lucene/LuceneIndexCreationPersistenceIntegrationTest.java
@@ -112,7 +112,7 @@ public void shouldNotUseDiskStoreWhenUserRegionIsNotPersistent() {
 
   @Test
   @Parameters({"true", "false"})
-  public void shouldUseDiskSynchronousWhenUserRegionHasDiskSynchronous(boolean synchronous) {
+  public void aeqShouldAlwaysBeDiskSynchronousWhenUserRegionIsEither(boolean synchronous) {
     createIndex(cache, "text");
     cache.createRegionFactory(RegionShortcut.PARTITION_PERSISTENT).setDiskSynchronous(synchronous)
         .create(REGION_NAME);
@@ -122,7 +122,7 @@ public void shouldUseDiskSynchronousWhenUserRegionHasDiskSynchronous(boolean syn
       assertTrue(region.isDiskSynchronous());
     });
     AsyncEventQueue queue = getIndexQueue(cache);
-    assertEquals(synchronous, queue.isDiskSynchronous());
+    assertTrue(queue.isDiskSynchronous());
     assertEquals(true, queue.isPersistent());
   }