Skip to content

Commit

Permalink
Improve debug information for docker auth, and expose an environment …
Browse files Browse the repository at this point in the history
…variable. (pantsbuild#18599)

Improve debug information for docker auth, and expose one additional
fundamental environment variable.

Although we could potentially create an option to allow for exposing
additional environment variables to `pantsd`, the ones which have been
required so far are fundamental, and don't imply the need for an option.
Time will tell though.
  • Loading branch information
stuhood authored Mar 27, 2023
1 parent fb66bd8 commit cd832f2
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions src/python/pants/pantsd/pants_daemon.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
# https://github.com/keirlawson/docker_credential/commit/0c42d0f3c76a7d5f699d4d1e8b9747f799cf6116
"HOME",
"PATH",
"USER",
]


Expand Down
4 changes: 2 additions & 2 deletions src/rust/engine/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/rust/engine/process_execution/docker/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ async-trait = "0.1"
async-lock = "2.5"
bollard = { git = "https://github.com/fussybeaver/bollard.git", rev = "2d66d11b44aeff0373ece3d64a44b243e5152973" }
bollard-stubs = { git = "https://github.com/fussybeaver/bollard.git", rev = "2d66d11b44aeff0373ece3d64a44b243e5152973" }
docker_credential = "1.1"
docker_credential = "1.2"
fs = { path = "../../fs" }
futures = "0.3"
log = "0.4"
Expand Down

0 comments on commit cd832f2

Please sign in to comment.