config.Mapping: Conform to ifupdown's mapping-script interface

This doesn't get passed through the shell, it should be a single path to a script which is given the interface name as an argument. Signed-off-by: Kyle Moffett <[email protected]>
kmoffett · Jan 2, 2013 · d43f5d1 · d43f5d1
1 parent 0ef9fc6
commit d43f5d1
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/ifupdown_ng/config.py b/ifupdown_ng/config.py
@@ -157,7 +157,7 @@ def should_map(self, config_name):
 
 	def perform_mapping(self, config_name):
 		## FIXME(knuq): Set up and pass 'env='
-		proc = subprocess.Popen(self.script, shell=True,
+		proc = subprocess.Popen((self.script, config_name),
 				stdin=subprocess.PIPE,
 				stdout=subprocess.PIPE)
 		output = proc.communicate(input=''.join(self.script_input))