Upgrade metrics_center to write into GCS buckets (flutter#24022)

knopp · Jan 29, 2021 · 2a45e19 · 2a45e19
1 parent 39f1bca
commit 2a45e19
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/testing/benchmark/bin/parse_and_send.dart b/testing/benchmark/bin/parse_and_send.dart
@@ -41,15 +41,18 @@ Future<FlutterDestination> connectFlutterDestination() async {
   const String kTokenPath = 'TOKEN_PATH';
   const String kGcpProject = 'GCP_PROJECT';
   final Map<String, String> env = Platform.environment;
+  final bool isTesting = env['IS_TESTING'] == 'true';
   if (env.containsKey(kTokenPath) && env.containsKey(kGcpProject)) {
     return FlutterDestination.makeFromAccessToken(
       File(env[kTokenPath]).readAsStringSync(),
       env[kGcpProject],
+      isTesting: isTesting,
     );
   }
   return await FlutterDestination.makeFromCredentialsJson(
     jsonDecode(Platform.environment['BENCHMARK_GCP_CREDENTIALS'])
         as Map<String, dynamic>,
+    isTesting: isTesting,
   );
 }
 

diff --git a/testing/benchmark/pubspec.yaml b/testing/benchmark/pubspec.yaml
@@ -3,7 +3,7 @@ name: flutter_engine_benchmark
 dependencies:
   git: any
 
-  metrics_center: 0.0.4
+  metrics_center: 0.0.8
 
 dev_dependencies:
   test: any

diff --git a/testing/benchmark/test/parse_and_send_test.dart b/testing/benchmark/test/parse_and_send_test.dart
@@ -24,6 +24,7 @@ void main() {
       'example/txt_benchmarks.json',
     ], environment: <String, String>{
       'BENCHMARK_GCP_CREDENTIALS': testCred,
+      'IS_TESTING': 'true',
     });
   });
 
@@ -44,6 +45,7 @@ void main() {
     ], environment: <String, String>{
       'TOKEN_PATH': tokenPath,
       'GCP_PROJECT': testCred['project_id'] as String,
+      'IS_TESTING': 'true',
     });
     expect(result.exitCode, 0);
   });