Skip to content

Commit

Permalink
Rename layoutGoals to kLayoutGoals to enforce lints on headers. (f…
Browse files Browse the repository at this point in the history
…lutter#46054)

This is required to eventually land flutter/flutter#134969 (lint header files).
  • Loading branch information
matanlurey authored Sep 19, 2023
1 parent 28f14e6 commit 7ef3d8c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ - (void)buildLayout {

std::map<uint32_t, LayoutGoal> mandatoryGoalsByChar;
std::map<uint32_t, LayoutGoal> usLayoutGoalsByKeyCode;
for (const LayoutGoal& goal : flutter::layoutGoals) {
for (const LayoutGoal& goal : flutter::kLayoutGoals) {
if (goal.mandatory) {
mandatoryGoalsByChar[goal.keyChar] = goal;
} else {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@
const uint64_t kCapsLockPhysicalKey = 0x00070039;
const uint64_t kCapsLockLogicalKey = 0x100000104;

const std::vector<LayoutGoal> layoutGoals = {
const std::vector<LayoutGoal> kLayoutGoals = {
LayoutGoal{0x31, 0x20, false}, // Space
LayoutGoal{0x27, 0x22, false}, // Quote
LayoutGoal{0x2b, 0x2c, false}, // Comma
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,6 @@ typedef struct {
* All keys that Flutter wants to derive layout for, and guides on how to derive
* them.
*/
extern const std::vector<LayoutGoal> layoutGoals;
extern const std::vector<LayoutGoal> kLayoutGoals;

} // namespace flutter

0 comments on commit 7ef3d8c

Please sign in to comment.