Skip to content

Commit

Permalink
remove maxdiff for backdrop_filter_clip_moved (flutter#27634)
Browse files Browse the repository at this point in the history
  • Loading branch information
ferhatb authored Jul 23, 2021
1 parent 4c14525 commit deee995
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
2 changes: 1 addition & 1 deletion lib/web_ui/test/html/canvas_context_golden_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ void testMain() async {
sceneElement.append(engineCanvas.rootElement);
html.document.body!.append(sceneElement);
// TODO(yjbanov): 10% diff rate is excessive. Update goldens.
await matchGoldenFile('$fileName.png', region: region, maxDiffRatePercent: 10);
await matchGoldenFile('$fileName.png', region: region);
} finally {
// The page is reused across tests, so remove the element after taking the
// Scuba screenshot.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@ void testMain() async {
.build()
.webOnlyRootElement!);

await matchGoldenFile('backdrop_filter_clip.png', region: region,
maxDiffRatePercent: 0.8);
await matchGoldenFile('backdrop_filter_clip.png', region: region);
});

test('Background should only blur at ancestor clip boundary after move', () async {
Expand Down Expand Up @@ -110,8 +109,7 @@ void testMain() async {
.build()
.webOnlyRootElement!);

await matchGoldenFile('backdrop_filter_clip_moved.png', region: region,
maxDiffRatePercent: 0.8);
await matchGoldenFile('backdrop_filter_clip_moved.png', region: region);
});

// The blur filter should be applied to the background inside the clip even
Expand Down Expand Up @@ -142,8 +140,8 @@ void testMain() async {
.build()
.webOnlyRootElement!);

await matchGoldenFile('backdrop_filter_no_child_rendering.png', region: region,
maxDiffRatePercent: 0.8);
await matchGoldenFile('backdrop_filter_no_child_rendering.png',
region: region);
});
}

Expand Down

0 comments on commit deee995

Please sign in to comment.