fix(race): Fix hanging processes for incomplete race tasks

kofno · Jan 12, 2019 · c18f313 · c18f313
1 parent eaa3f34
commit c18f313
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/Task.ts b/src/Task.ts
@@ -86,17 +86,23 @@ class Task<E, T> {
 
     return new Task((reject, resolve) => {
       let resolved = false;
+      const cancels: Array<() => void> = [];
+
       const resolveIf = (result: T) => {
         if (!resolved) {
           resolved = true;
           resolve(result);
+          cancels.forEach(fn => fn());
         }
       };
       // tslint:disable-next-line:prefer-for-of
       for (let i = 0; i < ts.length; i++) {
-        ts[i].fork(reject, resolveIf);
+        cancels.push(ts[i].fork(reject, resolveIf));
       }
-      return noop;
+
+      return () => {
+        cancels.forEach(fn => fn());
+      };
     });
   }